Suppress compiler and linker warnings in v8 test binaries

Suppress compiler and linker warnings in v8 test binaries

VC++ complains about truncation of integer constants despite use of
static_cast. This isn't very helpful as it gives no way of suppressing
the warning in code, so this change suppresses it on the command line.

Additionally, the linker complains about importing of locally defined
functions in component builds. Until this is fixed the warnings should
be suppressed.

NOTRY=true

Committed: https://crrev.com/dea0d7474745f05948a9acfced2b3891d86ad133
Cr-Commit-Position: refs/heads/master@{#36695}

[brucedawson, 2016-06-02 21:44:24]

Description was changed from

==========
Suppress C4309 truncation warning in some test binaries

VC++ complains about truncation of integer constants despite use of
static_cast. This isn't very helpful as it gives no way of suppressing
the warning in code, so this change suppresses it on the command line.
==========

to

==========
Suppress compiler and linker warnings in v8 test binaries

VC++ complains about truncation of integer constants despite use of
static_cast. This isn't very helpful as it gives no way of suppressing
the warning in code, so this change suppresses it on the command line.

Additionally, the linker complains about importing of locally defined
functions in component builds. Until this is fixed the warnings should
be suppressed.
==========

[brucedawson, 2016-06-02 21:44:24]

brucedawson@chromium.org changed reviewers:
+ jochen@chromium.org, machenbach@chromium.org

[brucedawson, 2016-06-02 21:47:40]

This suppresses the compiler and linker warnings. The compiler warning
suppression seems reasonable but I'm not thrilled with the linker warning
suppression - it seems like it is papering over real issues.

We need some sort of fix for this in order to unblock the gn transition - both
https://codereview.chromium.org/2031063002/ and
https://codereview.chromium.org/2030823002/ are blocked.

[Michael Achenbach, 2016-06-03 07:39:09]

Description was changed from

==========
Suppress compiler and linker warnings in v8 test binaries

VC++ complains about truncation of integer constants despite use of
static_cast. This isn't very helpful as it gives no way of suppressing
the warning in code, so this change suppresses it on the command line.

Additionally, the linker complains about importing of locally defined
functions in component builds. Until this is fixed the warnings should
be suppressed.
==========

to

==========
Suppress compiler and linker warnings in v8 test binaries

VC++ complains about truncation of integer constants despite use of
static_cast. This isn't very helpful as it gives no way of suppressing
the warning in code, so this change suppresses it on the command line.

Additionally, the linker complains about importing of locally defined
functions in component builds. Until this is fixed the warnings should
be suppressed.

NOTRY=true
==========

[Michael Achenbach, 2016-06-03 07:40:02]

lgtm to unblock. We'll try to get rid of this again after the chromium win gn
trybots compile those targets.

[Michael Achenbach, 2016-06-03 08:19:02]

I'll land this so that it gets rolled into chromium soon.

[Michael Achenbach, 2016-06-03 08:19:05]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-06-03 08:19:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028353004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028353004/20001

[commit-bot: I haz the power, 2016-06-03 08:21:16]

Description was changed from

==========
Suppress compiler and linker warnings in v8 test binaries

VC++ complains about truncation of integer constants despite use of
static_cast. This isn't very helpful as it gives no way of suppressing
the warning in code, so this change suppresses it on the command line.

Additionally, the linker complains about importing of locally defined
functions in component builds. Until this is fixed the warnings should
be suppressed.

NOTRY=true
==========

to

==========
Suppress compiler and linker warnings in v8 test binaries

VC++ complains about truncation of integer constants despite use of
static_cast. This isn't very helpful as it gives no way of suppressing
the warning in code, so this change suppresses it on the command line.

Additionally, the linker complains about importing of locally defined
functions in component builds. Until this is fixed the warnings should
be suppressed.

NOTRY=true
==========

[commit-bot: I haz the power, 2016-06-03 08:21:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-03 08:23:27]

Description was changed from

==========
Suppress compiler and linker warnings in v8 test binaries

VC++ complains about truncation of integer constants despite use of
static_cast. This isn't very helpful as it gives no way of suppressing
the warning in code, so this change suppresses it on the command line.

Additionally, the linker complains about importing of locally defined
functions in component builds. Until this is fixed the warnings should
be suppressed.

NOTRY=true
==========

to

==========
Suppress compiler and linker warnings in v8 test binaries

VC++ complains about truncation of integer constants despite use of
static_cast. This isn't very helpful as it gives no way of suppressing
the warning in code, so this change suppresses it on the command line.

Additionally, the linker complains about importing of locally defined
functions in component builds. Until this is fixed the warnings should
be suppressed.

NOTRY=true

Committed: https://crrev.com/dea0d7474745f05948a9acfced2b3891d86ad133
Cr-Commit-Position: refs/heads/master@{#36695}
==========

[commit-bot: I haz the power, 2016-06-03 08:23:28]

Patchset 2 (id:??) landed as
https://crrev.com/dea0d7474745f05948a9acfced2b3891d86ad133
Cr-Commit-Position: refs/heads/master@{#36695}