Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: test/cctest/BUILD.gn

Issue 2028353004: Suppress compiler and linker warnings in v8 test binaries (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Suppress linker warnings Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/unittests/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/BUILD.gn
diff --git a/test/cctest/BUILD.gn b/test/cctest/BUILD.gn
index 6a7f1912525b30fb317ef7a46e867a7876e473fd..1461c920ee1fe08844d5bda189f291c9bca757ed 100644
--- a/test/cctest/BUILD.gn
+++ b/test/cctest/BUILD.gn
@@ -316,6 +316,18 @@ executable("cctest") {
} else {
deps += [ "../..:v8" ]
}
+
+ if (is_win) {
+ # This warning is benignly triggered by the U16 and U32 macros in
+ # bytecode-utils.h.
+ # C4309: 'static_cast': truncation of constant value
+ cflags = [ "/wd4309" ]
+
+ # Suppress warnings about importing locally defined symbols.
+ if (is_component_build) {
+ ldflags = [ "/ignore:4049", "/ignore:4217" ]
+ }
+ }
}
action("resources") {
« no previous file with comments | « no previous file | test/unittests/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698