Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 2028333002: Revert of Extend HasProperty stub with dictionary-mode and double-elements objects support. (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Extend HasProperty stub with dictionary-mode and double-elements objects support. (patchset #8 id:280001 of https://codereview.chromium.org/1995453002/ ) Reason for revert: There are crashes on Win32 and Win64 bots. Original issue's description: > Extend HasProperty stub with dictionary-mode, string wrapper and double-elements objects support. > > This CL also replaces some Branch() usages with GotoIf/GotoUnless. > > BUG=v8:2743 > LOG=Y > > Committed: https://crrev.com/24066b6df4259b302edfa1db884c479008776a7e > Cr-Commit-Position: refs/heads/master@{#36657} TBR=verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:2743 Committed: https://crrev.com/9b4f836a2d168644d657e2d86f4d50ebe027e8b2 Cr-Commit-Position: refs/heads/master@{#36659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+571 lines, -1552 lines) Patch
M src/code-stub-assembler.h View 5 chunks +8 lines, -40 lines 0 comments Download
M src/code-stub-assembler.cc View 7 chunks +97 lines, -383 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/objects.h View 6 chunks +34 lines, -11 lines 0 comments Download
M src/objects.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/utils.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M test/cctest/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M test/cctest/cctest.gyp View 2 chunks +1 line, -1 line 0 comments Download
M test/cctest/compiler/function-tester.h View 4 chunks +19 lines, -37 lines 0 comments Download
A test/cctest/compiler/test-code-stub-assembler.cc View 1 chunk +394 lines, -0 lines 0 comments Download
D test/cctest/test-code-stub-assembler.cc View 1 chunk +0 lines, -1059 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Igor Sheludko
Created Revert of Extend HasProperty stub with dictionary-mode and double-elements objects support.
4 years, 6 months ago (2016-06-01 21:08:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028333002/1
4 years, 6 months ago (2016-06-01 21:08:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 21:08:32 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 21:10:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b4f836a2d168644d657e2d86f4d50ebe027e8b2
Cr-Commit-Position: refs/heads/master@{#36659}

Powered by Google App Engine
This is Rietveld 408576698