Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: src/code-stub-assembler.h

Issue 2028333002: Revert of Extend HasProperty stub with dictionary-mode and double-elements objects support. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/code-stub-assembler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stub-assembler.h
diff --git a/src/code-stub-assembler.h b/src/code-stub-assembler.h
index 8d964b1362aef8b1b0dafcd4734fc8a47023658e..ac08b5073e45223832029466bf4d3d347b2cd129 100644
--- a/src/code-stub-assembler.h
+++ b/src/code-stub-assembler.h
@@ -40,8 +40,6 @@
compiler::Node* NoContextConstant();
compiler::Node* NullConstant();
compiler::Node* UndefinedConstant();
- compiler::Node* TheHoleConstant();
- compiler::Node* HashSeed();
compiler::Node* StaleRegisterConstant();
// Float64 operations.
@@ -114,8 +112,6 @@
compiler::Node* LoadMap(compiler::Node* object);
// Load the instance type of an HeapObject.
compiler::Node* LoadInstanceType(compiler::Node* object);
- // Load the properties backing store of a JSObject.
- compiler::Node* LoadProperties(compiler::Node* object);
// Load the elements backing store of a JSObject.
compiler::Node* LoadElements(compiler::Node* object);
// Load the length of a fixed array base instance.
@@ -132,20 +128,11 @@
compiler::Node* LoadMapDescriptors(compiler::Node* map);
// Load the prototype of a map.
compiler::Node* LoadMapPrototype(compiler::Node* map);
+
+ // Load the hash field of a name.
+ compiler::Node* LoadNameHash(compiler::Node* name);
// Load the instance size of a Map.
compiler::Node* LoadMapInstanceSize(compiler::Node* map);
-
- // Load the hash field of a name.
- compiler::Node* LoadNameHashField(compiler::Node* name);
- // Load the hash value of a name. If {if_hash_not_computed} label
- // is specified then it also checks if hash is actually computed.
- compiler::Node* LoadNameHash(compiler::Node* name,
- Label* if_hash_not_computed = nullptr);
-
- // Load length field of a String object.
- compiler::Node* LoadStringLength(compiler::Node* object);
- // Load value field of a JSValue object.
- compiler::Node* LoadJSValueValue(compiler::Node* object);
compiler::Node* AllocateUninitializedFixedArray(compiler::Node* length);
@@ -153,11 +140,6 @@
compiler::Node* LoadFixedArrayElement(
compiler::Node* object, compiler::Node* int32_index,
int additional_offset = 0,
- ParameterMode parameter_mode = INTEGER_PARAMETERS);
- // Load an array element from a FixedDoubleArray.
- compiler::Node* LoadFixedDoubleArrayElement(
- compiler::Node* object, compiler::Node* int32_index,
- MachineType machine_type, int additional_offset = 0,
ParameterMode parameter_mode = INTEGER_PARAMETERS);
// Context manipulation
@@ -248,31 +230,17 @@
// Various building blocks for stubs doing property lookups.
void TryToName(compiler::Node* key, Label* if_keyisindex, Variable* var_index,
- Label* if_keyisunique, Label* if_bailout);
-
- static const int kInlinedDictionaryProbes = 4;
- template <typename Dictionary>
- void NameDictionaryLookup(compiler::Node* dictionary,
- compiler::Node* unique_name, Label* if_found,
- Variable* var_entry, Label* if_not_found,
- int inlined_probes = kInlinedDictionaryProbes);
-
- compiler::Node* ComputeIntegerHash(compiler::Node* key, compiler::Node* seed);
-
- template <typename Dictionary>
- void NumberDictionaryLookup(compiler::Node* dictionary, compiler::Node* key,
- Label* if_found, Variable* var_entry,
- Label* if_not_found);
+ Label* if_keyisunique, Label* call_runtime);
void TryLookupProperty(compiler::Node* object, compiler::Node* map,
- compiler::Node* instance_type,
- compiler::Node* unique_name, Label* if_found,
- Label* if_not_found, Label* if_bailout);
+ compiler::Node* instance_type, compiler::Node* name,
+ Label* if_found, Label* if_not_found,
+ Label* call_runtime);
void TryLookupElement(compiler::Node* object, compiler::Node* map,
compiler::Node* instance_type, compiler::Node* index,
Label* if_found, Label* if_not_found,
- Label* if_bailout);
+ Label* call_runtime);
// Instanceof helpers.
// ES6 section 7.3.19 OrdinaryHasInstance (C, O)
« no previous file with comments | « no previous file | src/code-stub-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698