Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2028303005: Add PTHREAD_PRIO_INHERIT to POSIX Locks (Closed)

Created:
4 years, 6 months ago by robliao
Modified:
4 years, 4 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org, gab, fdoray, jschuh, jln (very slow on Chromium), rickyz (no longer on Chrome)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PTHREAD_PRIO_INHERIT to POSIX Locks The Browser Task Scheduler will be using thread priorities. PTHREAD_PRIO_INHERIT will help avoid priority inversion with the use of thread priorities. BUG=611856

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR Feedback #

Total comments: 4

Patch Set 3 : CR Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -25 lines) Patch
M base/synchronization/lock.h View 1 2 2 chunks +24 lines, -0 lines 0 comments Download
M base/synchronization/lock_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M base/synchronization/lock_impl_posix.cc View 1 2 2 chunks +39 lines, -6 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc View 4 chunks +4 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc View 4 chunks +30 lines, -18 lines 0 comments Download

Messages

Total messages: 41 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028303005/1
4 years, 6 months ago (2016-06-02 00:03:55 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239289)
4 years, 6 months ago (2016-06-02 01:59:50 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028303005/1
4 years, 6 months ago (2016-06-02 17:12:08 UTC) #6
robliao
danakj: Please review base/* for this CL. Thanks! Perf impact for mac: https://codereview.chromium.org/1971093004/ Perf impact ...
4 years, 6 months ago (2016-06-02 20:49:10 UTC) #8
danakj
This looks kinda bad: http://storage.googleapis.com/chromium-telemetry/html-results/results-2016-05-12_22-59-31 no?
4 years, 6 months ago (2016-06-02 20:56:37 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/240157)
4 years, 6 months ago (2016-06-02 21:12:34 UTC) #11
robliao
On 2016/06/02 20:56:37, danakj wrote: > This looks kinda bad: > http://storage.googleapis.com/chromium-telemetry/html-results/results-2016-05-12_22-59-31 > no? The ...
4 years, 6 months ago (2016-06-02 21:39:09 UTC) #12
danakj
I'd like to have someone review the sandbox stuff, it's strange and foreign, so I ...
4 years, 6 months ago (2016-06-02 21:59:21 UTC) #13
robliao
> I'd like to have someone review the sandbox stuff, it's strange and foreign, so ...
4 years, 6 months ago (2016-06-02 22:17:48 UTC) #14
danakj
On Thu, Jun 2, 2016 at 3:17 PM, <robliao@chromium.org> wrote: > > I'd like to ...
4 years, 6 months ago (2016-06-02 22:19:31 UTC) #15
robliao
rickyz@chromium.org: Please review changes in sandbox/* Thanks!
4 years, 6 months ago (2016-06-02 22:25:24 UTC) #17
robliao
rickyz is OOO this week, adding jln. jln@chromium.org: Please review changes in sandbox/* Thanks!
4 years, 6 months ago (2016-06-02 22:30:36 UTC) #19
gab
Drive-by, thanks for doing this :-) https://codereview.chromium.org/2028303005/diff/20001/base/synchronization/lock.h File base/synchronization/lock.h (right): https://codereview.chromium.org/2028303005/diff/20001/base/synchronization/lock.h#newcode21 base/synchronization/lock.h:21: // available. Lock::PriorityInheritanceAvailable ...
4 years, 6 months ago (2016-06-07 12:28:19 UTC) #20
robliao
https://codereview.chromium.org/2028303005/diff/20001/base/synchronization/lock.h File base/synchronization/lock.h (right): https://codereview.chromium.org/2028303005/diff/20001/base/synchronization/lock.h#newcode21 base/synchronization/lock.h:21: // available. Lock::PriorityInheritanceAvailable must still be checked. On 2016/06/07 ...
4 years, 6 months ago (2016-06-07 14:11:04 UTC) #22
robliao
On 2016/06/07 14:11:04, robliao wrote: > https://codereview.chromium.org/2028303005/diff/20001/base/synchronization/lock.h > File base/synchronization/lock.h (right): > > https://codereview.chromium.org/2028303005/diff/20001/base/synchronization/lock.h#newcode21 > ...
4 years, 6 months ago (2016-06-10 18:31:25 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028303005/60001
4 years, 6 months ago (2016-06-13 23:28:43 UTC) #25
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 01:34:51 UTC) #27
robliao
Moving up a directory level. jschuh: Please review the changes in sandbox/*. Thanks!
4 years, 6 months ago (2016-06-14 17:13:42 UTC) #29
robliao
Adding mdempsky@ on recommendation by jschuh@. mdempsky@chromium.org: Please review changes in sandbox/*. Thanks!
4 years, 6 months ago (2016-06-14 23:23:26 UTC) #33
mdempsky
Hm, this is a bit tricky because we actually specifically wanted to avoid allowing futex's ...
4 years, 6 months ago (2016-06-16 20:45:52 UTC) #35
robliao
On 2016/06/16 20:45:52, mdempsky wrote: > Hm, this is a bit tricky because we actually ...
4 years, 6 months ago (2016-06-16 20:58:50 UTC) #36
mdempsky
On 2016/06/16 20:58:50, robliao wrote: > Do you have any recommendations on alternatives? Nothing concrete, ...
4 years, 6 months ago (2016-06-16 21:09:10 UTC) #37
robliao
On 2016/06/16 21:09:10, mdempsky wrote: > On 2016/06/16 20:58:50, robliao wrote: > > Do you ...
4 years, 6 months ago (2016-06-16 21:33:42 UTC) #38
mdempsky
On 2016/06/16 21:33:42, robliao wrote: > "help avoid" may not have been assertive enough on ...
4 years, 6 months ago (2016-06-16 21:51:40 UTC) #39
robliao
On 2016/06/16 21:51:40, mdempsky wrote: > On 2016/06/16 21:33:42, robliao wrote: > > "help avoid" ...
4 years, 6 months ago (2016-06-17 17:44:13 UTC) #40
robliao
4 years, 4 months ago (2016-07-29 21:31:28 UTC) #41
Message was sent while issue was closed.
Closing - Superseded by https://codereview.chromium.org/2178503003/

Powered by Google App Engine
This is Rietveld 408576698