Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: base/synchronization/lock_impl_posix.cc

Issue 2028303005: Add PTHREAD_PRIO_INHERIT to POSIX Locks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR Feedback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/synchronization/lock_impl.h" 5 #include "base/synchronization/lock_impl.h"
6 6
7 #include <errno.h> 7 #include <errno.h>
8 #include <string.h> 8 #include <string.h>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/synchronization/lock.h"
12 #include "base/version.h"
13
14 #if defined(OS_LINUX)
15 #include <tuple>
16 #include <gnu/libc-version.h>
17 #endif
11 18
12 namespace base { 19 namespace base {
13 namespace internal { 20 namespace internal {
14 21
15 LockImpl::LockImpl() { 22 LockImpl::LockImpl() {
16 #ifndef NDEBUG
17 // In debug, setup attributes for lock error checking.
18 pthread_mutexattr_t mta; 23 pthread_mutexattr_t mta;
19 int rv = pthread_mutexattr_init(&mta); 24 int rv = pthread_mutexattr_init(&mta);
20 DCHECK_EQ(rv, 0) << ". " << strerror(rv); 25 DCHECK_EQ(rv, 0) << ". " << strerror(rv);
26 #if PRIORITY_INHERITANCE_LOCKS_POSSIBLE()
27 if (PriorityInheritanceAvailable()) {
28 rv = pthread_mutexattr_setprotocol(&mta, PTHREAD_PRIO_INHERIT);
29 }
30 DCHECK_EQ(rv, 0) << ". " << strerror(rv);
31 #endif
32 #ifndef NDEBUG
33 // In debug, setup attributes for lock error checking.
21 rv = pthread_mutexattr_settype(&mta, PTHREAD_MUTEX_ERRORCHECK); 34 rv = pthread_mutexattr_settype(&mta, PTHREAD_MUTEX_ERRORCHECK);
22 DCHECK_EQ(rv, 0) << ". " << strerror(rv); 35 DCHECK_EQ(rv, 0) << ". " << strerror(rv);
36 #endif
23 rv = pthread_mutex_init(&native_handle_, &mta); 37 rv = pthread_mutex_init(&native_handle_, &mta);
24 DCHECK_EQ(rv, 0) << ". " << strerror(rv); 38 DCHECK_EQ(rv, 0) << ". " << strerror(rv);
25 rv = pthread_mutexattr_destroy(&mta); 39 rv = pthread_mutexattr_destroy(&mta);
26 DCHECK_EQ(rv, 0) << ". " << strerror(rv); 40 DCHECK_EQ(rv, 0) << ". " << strerror(rv);
27 #else
28 // In release, go with the default lock attributes.
29 pthread_mutex_init(&native_handle_, NULL);
30 #endif
31 } 41 }
32 42
33 LockImpl::~LockImpl() { 43 LockImpl::~LockImpl() {
34 int rv = pthread_mutex_destroy(&native_handle_); 44 int rv = pthread_mutex_destroy(&native_handle_);
35 DCHECK_EQ(rv, 0) << ". " << strerror(rv); 45 DCHECK_EQ(rv, 0) << ". " << strerror(rv);
36 } 46 }
37 47
38 bool LockImpl::Try() { 48 bool LockImpl::Try() {
39 int rv = pthread_mutex_trylock(&native_handle_); 49 int rv = pthread_mutex_trylock(&native_handle_);
40 DCHECK(rv == 0 || rv == EBUSY) << ". " << strerror(rv); 50 DCHECK(rv == 0 || rv == EBUSY) << ". " << strerror(rv);
41 return rv == 0; 51 return rv == 0;
42 } 52 }
43 53
44 void LockImpl::Lock() { 54 void LockImpl::Lock() {
45 int rv = pthread_mutex_lock(&native_handle_); 55 int rv = pthread_mutex_lock(&native_handle_);
46 DCHECK_EQ(rv, 0) << ". " << strerror(rv); 56 DCHECK_EQ(rv, 0) << ". " << strerror(rv);
47 } 57 }
48 58
49 void LockImpl::Unlock() { 59 void LockImpl::Unlock() {
50 int rv = pthread_mutex_unlock(&native_handle_); 60 int rv = pthread_mutex_unlock(&native_handle_);
51 DCHECK_EQ(rv, 0) << ". " << strerror(rv); 61 DCHECK_EQ(rv, 0) << ". " << strerror(rv);
52 } 62 }
53 63
64 // static
65 bool LockImpl::PriorityInheritanceAvailable() {
66 #if PRIORITY_INHERITANCE_LOCKS_POSSIBLE()
67 #if defined(OS_LINUX)
68 // glibc Bug 14652: https://sourceware.org/bugzilla/show_bug.cgi?id=14652
69 // Fixed in glibc 2.17.
70 // Priority inheritance mutexes may deadlock with condition variables during
71 // recacquisition of the mutex after the condition variable is signalled.
72 Version version(gnu_get_libc_version());
73 if (!version.IsValid() || version.components().size() != 2)
74 return false;
75
76 return std::tie(version.components()[0], version.components()[1]) >=
77 std::make_tuple(2, 17);
78
79 #else // defined(OS_LINUX)
80 return true;
81 #endif // defined(OS_LINUX)
82 #else // PRIORITY_INHERITANCE_LOCKS_POSSIBLE()
83 return false;
84 #endif // PRIORITY_INHERITANCE_LOCKS_POSSIBLE()
85 }
86
54 } // namespace internal 87 } // namespace internal
55 } // namespace base 88 } // namespace base
OLDNEW
« no previous file with comments | « base/synchronization/lock_impl.h ('k') | sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698