Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Issue 2028173003: Refine ChromeVox's treatment of containers (Closed)

Created:
4 years, 6 months ago by David Tseng
Modified:
4 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refine ChromeVox's treatment of containers 1. merge ignored containers and ignored leaf nodes into one predicate 2. only visit containers that are also visited by the provided predicate. For example, an element will match against a focusable toolbar, but a line won't. 3. scan the initial subtree of a node when moving to the next node if either of the following are true: the node is a container or the node doesn't match the predicate (e.g. element). This takes care of syncing when the current range is on an arbitrary position in the tree. When moving backwards, the leaf predicate restricts how deeply the backwards movement syncs downwards in the tree. BUG=613473 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/709ec11a4037d0fd97cff6a395d63ef574044d72 Cr-Commit-Position: refs/heads/master@{#397737}

Patch Set 1 #

Messages

Total messages: 11 (6 generated)
David Tseng
4 years, 6 months ago (2016-06-01 17:46:17 UTC) #4
dmazzoni
lgtm
4 years, 6 months ago (2016-06-03 16:10:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028173003/1
4 years, 6 months ago (2016-06-03 16:33:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 17:18:08 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 17:19:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/709ec11a4037d0fd97cff6a395d63ef574044d72
Cr-Commit-Position: refs/heads/master@{#397737}

Powered by Google App Engine
This is Rietveld 408576698