Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3448)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

Issue 2028173003: Refine ChromeVox's treatment of containers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
index db1e3106833bcf20e9f7e1b407fb8bbaeff30b07..ed00e70881b075412a235036f8b38333b4f53b3f 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
@@ -132,9 +132,9 @@ TEST_F('CursorsTest', 'CharacterCursor', function() {
this.runCursorMovesOnDocument(this.simpleDoc, [
[CHARACTER, DIRECTIONAL, FORWARD, {index: 1, value: 'start '}],
[CHARACTER, DIRECTIONAL, BACKWARD, {index: 0, value: 'start '}],
- [CHARACTER, DIRECTIONAL, BACKWARD, {index: 0, value: undefined}],
+ // Bumps up against edge.
+ [CHARACTER, DIRECTIONAL, BACKWARD, {index: 0, value: 'start '}],
- [CHARACTER, DIRECTIONAL, FORWARD, {index: 0, value: 'start '}],
[CHARACTER, DIRECTIONAL, FORWARD, {index: 1, value: 'start '}],
[CHARACTER, DIRECTIONAL, FORWARD, {index: 2, value: 'start '}],
[CHARACTER, DIRECTIONAL, FORWARD, {index: 3, value: 'start '}],
@@ -198,9 +198,9 @@ TEST_F('CursorsTest', 'LineCursor', function() {
[LINE, DIRECTIONAL, FORWARD, {value: 'end'}],
[LINE, DIRECTIONAL, FORWARD, {value: 'end'}],
[LINE, DIRECTIONAL, BACKWARD, {value: 'same line'}],
- [LINE, DIRECTIONAL, BACKWARD, {value: undefined}],
- [LINE, BOUND, BACKWARD, {value: undefined}],
- [LINE, DIRECTIONAL, FORWARD, {value: 'start '}]]);
+ // Bump against an edge.
+ [LINE, DIRECTIONAL, BACKWARD, {value: 'same line'}],
+ [LINE, BOUND, BACKWARD, {value: 'start '}]]);
});
TEST_F('CursorsTest', 'CharacterRange', function() {
@@ -272,10 +272,10 @@ TEST_F('CursorsTest', 'LineRange', function() {
{value: 'start ', index: 0}, {value: 'same line', index: 9}],
[LINE, BACKWARD,
- {value: undefined, index: 0}, {value: undefined, index: 0}],
+ {value: 'start ', index: 0}, {value: 'same line', index: 9}]
], this.RANGE);
});
-
+
TEST_F('CursorsTest', 'DontSplitOnNodeNavigation', function() {
this.runWithLoadedTree(this.multiInlineDoc, function(root) {
var para = root.firstChild;
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698