Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Issue 2027843003: [Custom Tabs] Fix a bug that security icon might show for http (Closed)

Created:
4 years, 6 months ago by Ian Wen
Modified:
4 years, 6 months ago
Reviewers:
Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Custom Tabs] Fix a bug that security icon might show for http If the security icon state changes faster than the time it takes for Android to relayout, hide animation might be called even before the security icon's visibility has been flipped. This CL fixes the bug in this scenario. BUG=612939 Review-Url: https://codereview.chromium.org/2024173003 Cr-Commit-Position: refs/heads/master@{#396957} TBR=yusufo@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/4376e086baffb084b6e5fe02e011fbe466bc1853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java View 3 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ian Wen
4 years, 6 months ago (2016-06-01 19:12:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4376e086baffb084b6e5fe02e011fbe466bc1853 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698