Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2024173003: [Custom Tabs] Fix a bug that security icon might show for http (Closed)

Created:
4 years, 6 months ago by Ian Wen
Modified:
4 years, 6 months ago
Reviewers:
Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Custom Tabs] Fix a bug that security icon might show for http If the security icon state changes faster than the time it takes for Android to relayout, hide animation might be called even before the security icon's visibility has been flipped. This CL fixes the bug in this scenario. BUG=612939 Committed: https://crrev.com/ba21bb8491e53472c1878e8af4f8c2aab18ce336 Cr-Commit-Position: refs/heads/master@{#396957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java View 3 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ian Wen
PTAL. This is the fix for the security related bug that was marked as very ...
4 years, 6 months ago (2016-05-31 20:47:15 UTC) #2
Yusuf
lgtm
4 years, 6 months ago (2016-05-31 21:12:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024173003/1
4 years, 6 months ago (2016-05-31 21:12:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 22:38:07 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 22:40:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba21bb8491e53472c1878e8af4f8c2aab18ce336
Cr-Commit-Position: refs/heads/master@{#396957}

Powered by Google App Engine
This is Rietveld 408576698