Adjust color for printing list-item markers as we do for text.

Adjust color for printing list-item markers as we do for text.

BUG=459022
Committed: https://crrev.com/938950b5ff9598960f5c1943013611279799717e
Cr-Commit-Position: refs/heads/master@{#397099}

[rune, 2016-05-31 23:03:49]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 23:04:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027653004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027653004/1

[commit-bot: I haz the power, 2016-05-31 23:16:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 23:16:35]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[rune, 2016-06-01 06:31:57]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 06:32:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027653004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027653004/20001

[rune, 2016-06-01 06:33:15]

rune@opera.com changed reviewers:
+ pdr@chromium.org

[commit-bot: I haz the power, 2016-06-01 08:02:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 08:02:11]

Dry run: This issue passed the CQ dry run.

[rune, 2016-06-01 08:05:35]

rune@opera.com changed reviewers:
+ fs@opera.com

[fs, 2016-06-01 08:50:10]

lgtm

https://codereview.chromium.org/2027653004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp (right):

https://codereview.chromium.org/2027653004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp:87: if
(BoxPainter::shouldForceWhiteBackgroundForPrintEconomy(m_layoutListMarker.styleRef(),
m_layoutListMarker.listItem()->document()))
(I guess this could just be m_layoutListMarker.document(), it should handle the
anonymous nature of the marker. I guess this might be more direct though.)

[rune, 2016-06-01 09:43:31]

https://codereview.chromium.org/2027653004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp (right):

https://codereview.chromium.org/2027653004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp:87: if
(BoxPainter::shouldForceWhiteBackgroundForPrintEconomy(m_layoutListMarker.styleRef(),
m_layoutListMarker.listItem()->document()))
On 2016/06/01 08:50:10, fs wrote:
> (I guess this could just be m_layoutListMarker.document(), it should handle
the
> anonymous nature of the marker. I guess this might be more direct though.)

They are currently always anonymous, so LayoutObject::document() would then
always check m_node and call parent().

Are you fine with keeping this as it is?

[fs, 2016-06-01 10:22:59]

https://codereview.chromium.org/2027653004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp (right):

https://codereview.chromium.org/2027653004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp:87: if
(BoxPainter::shouldForceWhiteBackgroundForPrintEconomy(m_layoutListMarker.styleRef(),
m_layoutListMarker.listItem()->document()))
On 2016/06/01 at 09:43:31, rune wrote:
> On 2016/06/01 08:50:10, fs wrote:
> > (I guess this could just be m_layoutListMarker.document(), it should handle
the
> > anonymous nature of the marker. I guess this might be more direct though.)
> 
> They are currently always anonymous, so LayoutObject::document() would then
always check m_node and call parent().
> 
> Are you fine with keeping this as it is?

Yes.

[rune, 2016-06-01 10:41:33]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-06-01 10:41:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027653004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027653004/20001

[commit-bot: I haz the power, 2016-06-01 10:45:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-01 10:47:13]

Description was changed from

==========
Adjust color for printing list-item markers as we do for text.

BUG=459022
==========

to

==========
Adjust color for printing list-item markers as we do for text.

BUG=459022

Committed: https://crrev.com/938950b5ff9598960f5c1943013611279799717e
Cr-Commit-Position: refs/heads/master@{#397099}
==========

[commit-bot: I haz the power, 2016-06-01 10:47:14]

Patchset 2 (id:??) landed as
https://crrev.com/938950b5ff9598960f5c1943013611279799717e
Cr-Commit-Position: refs/heads/master@{#397099}