content/browser/service_worker/service_worker_metrics.h - Issue 2027583002: service worker: Avoid starting up for activation during shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_metrics.h

Issue 2027583002: service worker: Avoid starting up for activation during shutdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add unittest Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_job_unittest.cc ('k') | content/browser/service_worker/service_worker_metrics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_metrics.h

diff --git a/content/browser/service_worker/service_worker_metrics.h b/content/browser/service_worker/service_worker_metrics.h

index 31a9bb65fab2ec47646331d6f1846f438f3696ca..027ff79ebe7f9423c7061e20b89dfb8e3687cad2 100644

--- a/content/browser/service_worker/service_worker_metrics.h

+++ b/content/browser/service_worker/service_worker_metrics.h

@@ -166,7 +166,8 @@ class ServiceWorkerMetrics {

// Records the time taken to successfully stop a worker.

static void RecordStopWorkerTime(base::TimeDelta time);

- static void RecordActivateEventStatus(ServiceWorkerStatusCode status);

+ static void RecordActivateEventStatus(ServiceWorkerStatusCode status,

+ bool is_shutdown);

static void RecordInstallEventStatus(ServiceWorkerStatusCode status);

// Records how much of dispatched events are handled while a Service