content/browser/service_worker/service_worker_metrics.cc - Issue 2027583002: service worker: Avoid starting up for activation during shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 2027583002: service worker: Avoid starting up for activation during shutdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add unittest Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_metrics.h ('k') | content/browser/service_worker/service_worker_process_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_metrics.cc

diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc

index 16e636336c94dada98cdadd220cc74c52dbd07ec..902457d2533c33b32b15d2b99e9e58baa3638fec 100644

--- a/content/browser/service_worker/service_worker_metrics.cc

+++ b/content/browser/service_worker/service_worker_metrics.cc

@@ -312,9 +312,17 @@ void ServiceWorkerMetrics::RecordStopWorkerTime(base::TimeDelta time) {

}

void ServiceWorkerMetrics::RecordActivateEventStatus(

- ServiceWorkerStatusCode status) {

+ ServiceWorkerStatusCode status,

+ bool is_shutdown) {

UMA_HISTOGRAM_ENUMERATION("ServiceWorker.ActivateEventStatus", status,

SERVICE_WORKER_ERROR_MAX_VALUE);

+ if (is_shutdown) {

+ UMA_HISTOGRAM_ENUMERATION("ServiceWorker.ActivateEventStatus_InShutdown",

+ status, SERVICE_WORKER_ERROR_MAX_VALUE);

+ } else {

+ UMA_HISTOGRAM_ENUMERATION("ServiceWorker.ActivateEventStatus_NotInShutdown",

+ status, SERVICE_WORKER_ERROR_MAX_VALUE);

+ }

}

void ServiceWorkerMetrics::RecordInstallEventStatus(