cc: Add a tiling iterator that doesn't include borders

cc: Add a tiling iterator that doesn't include borders

This iterator is needed to reland
https://codereview.chromium.org/196343005/ correctly, as whether or not
a set of picture tiles can raster a particular rect needs to ignore
borders.

BUG=353346
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257688

[danakj, 2014-03-17 23:46:07]

LGTM

https://codereview.chromium.org/202753002/diff/20001/cc/base/tiling_data_unit...
File cc/base/tiling_data_unittest.cc (right):

https://codereview.chromium.org/202753002/diff/20001/cc/base/tiling_data_unit...
cc/base/tiling_data_unittest.cc:993: data, rect, expect_left, expect_top,
expect_right, expect_bottom, true);
nit: can you pass include_borders as a temp boolean instead of a bool literal
value?

https://codereview.chromium.org/202753002/diff/20001/cc/resources/picture_lay...
File cc/resources/picture_layer_tiling.cc (right):

https://codereview.chromium.org/202753002/diff/20001/cc/resources/picture_lay...
cc/resources/picture_layer_tiling.cc:751: true),
can you add comment that this bool is include_borders?

[enne (OOO), 2014-03-17 23:53:08]

https://codereview.chromium.org/202753002/diff/20001/cc/base/tiling_data_unit...
File cc/base/tiling_data_unittest.cc (right):

https://codereview.chromium.org/202753002/diff/20001/cc/base/tiling_data_unit...
cc/base/tiling_data_unittest.cc:993: data, rect, expect_left, expect_top,
expect_right, expect_bottom, true);
On 2014/03/17 23:46:07, danakj wrote:
> nit: can you pass include_borders as a temp boolean instead of a bool literal
> value?

Ok sure.  I thought it was clear with both functions next to each other, but I
can do that.

https://codereview.chromium.org/202753002/diff/20001/cc/resources/picture_lay...
File cc/resources/picture_layer_tiling.cc (right):

https://codereview.chromium.org/202753002/diff/20001/cc/resources/picture_lay...
cc/resources/picture_layer_tiling.cc:751: true),
On 2014/03/17 23:46:07, danakj wrote:
> can you add comment that this bool is include_borders?

Ok sure.  Comments always feel awkward to me, so I had just left it.

[enne (OOO), 2014-03-17 23:53:24]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-03-17 23:54:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/202753002/40001

[commit-bot: I haz the power, 2014-03-18 00:02:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-18 00:02:58]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[enne (OOO), 2014-03-18 00:56:22]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-03-18 00:59:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/202753002/40001

[commit-bot: I haz the power, 2014-03-18 07:28:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-18 07:28:38]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[danakj, 2014-03-18 16:50:21]

The CQ bit was checked by danakj@chromium.org

[enne (OOO), 2014-03-18 16:52:39]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-03-18 16:54:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/202753002/40001

[commit-bot: I haz the power, 2014-03-18 17:57:53]

Change committed as 257688