Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 2027513002: Add a stack of queues of elements with reaction queues. (Closed)

Created:
4 years, 8 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 8 months ago
Reviewers:
kojii
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ce-element-queue
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a stack of queues of elements with reaction queues. The ordering of custom element 'reactions' (various kinds of callbacks) is determined by a stack which is pushed and popped within the scope of an operation. The stack entry is a queue of involved elements; this is so callbacks occur in order. However each element gets callbacks in an internally consistent chronological order. To effect this, each element has an associated reaction queue. BUG=594918 Committed: https://crrev.com/e1a83859dd7df828f87fac61886f07f454dfffeb Cr-Commit-Position: refs/heads/master@{#396806}

Patch Set 1 #

Patch Set 2 : Rebase. #

Messages

Total messages: 12 (6 generated)
dominicc (has gone to gerrit)
PTAL Follow up from yesterday which uses the CustomElementReactionQueue.
4 years, 8 months ago (2016-05-31 02:16:13 UTC) #2
kojii
lgtm
4 years, 8 months ago (2016-05-31 02:33:29 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027513002/20001
4 years, 8 months ago (2016-05-31 06:07:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027513002/20001
4 years, 8 months ago (2016-05-31 07:13:02 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-05-31 09:14:28 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-05-31 09:16:51 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1a83859dd7df828f87fac61886f07f454dfffeb
Cr-Commit-Position: refs/heads/master@{#396806}

Powered by Google App Engine
This is Rietveld 408576698