Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h

Issue 2027513002: Add a stack of queues of elements with reaction queues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ce-element-queue
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueueTest.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h
similarity index 60%
copy from third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueueTest.cpp
copy to third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h
index 41ee46d2818b42d7c9ee9c2da08546fea616765a..3ab89c48b5e0c45cf43ffcd86a2e1b77cea7bd9e 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueueTest.cpp
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h
@@ -2,16 +2,18 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "core/dom/custom/CustomElementReactionQueue.h"
-
#include "core/dom/custom/CustomElementReaction.h"
-#include "testing/gtest/include/gtest/gtest.h"
-#include "wtf/text/AtomicString.h"
+
+#include "core/dom/custom/CustomElementReactionQueue.h"
+#include "platform/heap/Handle.h"
+#include "wtf/Noncopyable.h"
#include <initializer_list>
#include <vector>
namespace blink {
+class Element;
+
class Command : public GarbageCollectedFinalized<Command> {
WTF_MAKE_NONCOPYABLE(Command);
public:
@@ -97,50 +99,4 @@ private:
HeapVector<Member<Command>> m_commands;
};
-TEST(CustomElementReactionQueueTest, invokeReactions_one)
-{
- std::vector<char> log;
- CustomElementReactionQueue* queue = new CustomElementReactionQueue();
- queue->add(new TestReaction({new Log('a', log)}));
- queue->invokeReactions(nullptr);
- EXPECT_EQ(log, std::vector<char>({'a'}))
- << "the reaction should have been invoked";
-}
-
-TEST(CustomElementReactionQueueTest, invokeReactions_many)
-{
- std::vector<char> log;
- CustomElementReactionQueue* queue = new CustomElementReactionQueue();
- queue->add(new TestReaction({new Log('a', log)}));
- queue->add(new TestReaction({new Log('b', log)}));
- queue->add(new TestReaction({new Log('c', log)}));
- queue->invokeReactions(nullptr);
- EXPECT_EQ(log, std::vector<char>({'a', 'b', 'c'}))
- << "the reaction should have been invoked";
-}
-
-TEST(CustomElementReactionQueueTest, invokeReactions_recursive)
-{
- std::vector<char> log;
- CustomElementReactionQueue* queue = new CustomElementReactionQueue();
-
- CustomElementReaction* third = new TestReaction({
- new Log('c', log),
- new Recurse(queue)}); // "Empty" recursion
-
- CustomElementReaction* second = new TestReaction({
- new Log('b', log),
- new Enqueue(queue, third)}); // Unwinds one level of recursion
-
- CustomElementReaction* first = new TestReaction({
- new Log('a', log),
- new Enqueue(queue, second),
- new Recurse(queue)}); // Non-empty recursion
-
- queue->add(first);
- queue->invokeReactions(nullptr);
- EXPECT_EQ(log, std::vector<char>({'a', 'b', 'c'}))
- << "the reactions should have been invoked";
-}
-
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698