Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2027333003: Avoid unnecessary uses of GarbageCollectedFinalized<>. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid unnecessary uses of GarbageCollectedFinalized<>. R= BUG= Committed: https://crrev.com/f7c3ce462990c8cae80188686f75092772c5533c Cr-Commit-Position: refs/heads/master@{#397402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look.
4 years, 6 months ago (2016-06-02 11:00:22 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-02 11:16:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027333003/1
4 years, 6 months ago (2016-06-02 12:22:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 14:56:16 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f7c3ce462990c8cae80188686f75092772c5533c Cr-Commit-Position: refs/heads/master@{#397402}
4 years, 6 months ago (2016-06-02 14:59:19 UTC) #8
dominicc (has gone to gerrit)
4 years, 6 months ago (2016-06-06 06:20:50 UTC) #9
Message was sent while issue was closed. 
On 2016/06/02 at 14:59:19, commit-bot wrote:
> Patchset 1 (id:??) landed as
https://crrev.com/f7c3ce462990c8cae80188686f75092772c5533c
> Cr-Commit-Position: refs/heads/master@{#397402}

Thank you!

Powered by Google App Engine
This is Rietveld 408576698