Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1998)

Unified Diff: appengine/findit/model/wf_swarming_task.py

Issue 2027333002: [Findit] don't included skipped or unknown tests in swarming tasks into failed tests. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/wf_swarming_task.py
diff --git a/appengine/findit/model/wf_swarming_task.py b/appengine/findit/model/wf_swarming_task.py
index 14dc1596f07d9ea4c117165e2589fa9dad790bfd..95be960134cb6be895311b456d6a19179d48a309 100644
--- a/appengine/findit/model/wf_swarming_task.py
+++ b/appengine/findit/model/wf_swarming_task.py
@@ -53,6 +53,8 @@ class WfSwarmingTask(BaseBuildModel):
for test_name, test_statuses in self.tests_statuses.iteritems():
if test_statuses.get('SUCCESS'): # Test passed for some runs, flaky.
classified_tests['flaky_tests'].append(test_name)
+ elif test_statuses.get('SKIPPED') or test_statuses.get('UNKNOWN'):
+ classified_tests['other_tests'].append(test_name)
else:
# Here we consider a 'non-flaky' test to be 'reliable'.
# TODO(chanli): Check more test statuses.

Powered by Google App Engine
This is Rietveld 408576698