[Findit] don't included skipped or unknown tests in swarming tasks into failed tests.

appengine/findit/model/wf_swarming_task.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 
 from google.appengine.ext import ndb
 
 from model.base_build_model import BaseBuildModel
 from model import analysis_status
@@ skipping 28 matching lines @@
   # parameters need to be stored and analyzed later.
   parameters = ndb.JsonProperty(default={}, indexed=False, compressed=True)
 
   @property
   def classified_tests(self):
     """Classification of tests into lists of reliable and flaky tests.
 
     example format would be:
     {
         'flaky_tests': ['test1', 'test2', ...],
         'reliable_tests': ['test3', ...]

[lijeffrey, 2016/06/01 19:27:02]

Update the docstring too to put 'other_tests'.

side note: is 'other_tests' the same as 'unclassified_tests'?

[chanli, 2016/06/02 22:40:09]

Done. Essentially a skipped test is a test with a failed pre_ test, so this test
will be skipped. And there is another status 'UnKNOWN'. I have changed the logic
here to consider 'skipped' tests are reliable failure.

     }
     """
     classified_tests = defaultdict(list)
     for test_name, test_statuses in self.tests_statuses.iteritems():
       if test_statuses.get('SUCCESS'):  # Test passed for some runs, flaky.
         classified_tests['flaky_tests'].append(test_name)
+      elif test_statuses.get('SKIPPED') or test_statuses.get('UNKNOWN'):
+        classified_tests['other_tests'].append(test_name)
       else:
         # Here we consider a 'non-flaky' test to be 'reliable'.
         # TODO(chanli): Check more test statuses.
         classified_tests['reliable_tests'].append(test_name)
     return classified_tests
 
   @staticmethod
   def _CreateKey(
       master_name, builder_name, build_number, step_name):  # pragma: no cover
     build_id = BaseBuildModel.CreateBuildId(
         master_name, builder_name, build_number)
     return ndb.Key('WfBuild', build_id, 'WfSwarmingTask', step_name)
 
   @staticmethod
   def Create(
       master_name, builder_name, build_number, step_name):  # pragma: no cover
     return WfSwarmingTask(
         key=WfSwarmingTask._CreateKey(
             master_name, builder_name, build_number, step_name))
 
   @staticmethod
   def Get(
       master_name, builder_name, build_number, step_name):  # pragma: no cover
     return WfSwarmingTask._CreateKey(
         master_name, builder_name, build_number, step_name).get()