Migrate WaitableEvent to enum-based constructor in ui/

ui/views/mus/views_mus_test_suite.cc

Index: ui/views/mus/views_mus_test_suite.cc
diff --git a/ui/views/mus/views_mus_test_suite.cc b/ui/views/mus/views_mus_test_suite.cc
index 8290d54ef78bafcc0665b749805f1562cfe9abbd..c709f9dcb4b86c72b80801582d80ab2ec03f5c3d 100644
--- a/ui/views/mus/views_mus_test_suite.cc
+++ b/ui/views/mus/views_mus_test_suite.cc
@@ -67,7 +67,8 @@ std::unique_ptr<PlatformTestHelper> CreatePlatformTestHelper(
 class ShellConnection {
  public:
   ShellConnection() : thread_("Persistent shell connections") {
-    base::WaitableEvent wait(false, false);
+    base::WaitableEvent wait(base::WaitableEvent::ResetPolicy::AUTOMATIC,

[sky, 2016/06/01 19:18:35]

Did you consider making WaitableEvent take a bitmask of possible configurations
rather than two explicit policies? I suspect automatic and not-signaled are most
commonly used, so this code would become:

base::WaitableEvent event(base::WaitableEvent::DEFAULT);

Even better is to with a default value (which the style guide now allows) for
DEFAULT, so that this code becomes:

base::WaitableEvent event;

If you want to create manual, then it's:

event(base::WaitableEvent::MANUAL);

and if you want manual and signaled:

event(base::WaitableEvent::MANUAL | base::WaitableEvent::SIGNALED);

IMO this better matches how WaitableEvent is generally used and makes the api
nicer.

[gab, 2016/06/01 19:50:30]

Copied your suggestion on bug, danakj prefers the current API, please discuss it
there if you disagree.

+                             base::WaitableEvent::InitialState::NOT_SIGNALED);
     base::Thread::Options options;
     thread_.StartWithOptions(options);
     thread_.task_runner()->PostTask(
@@ -87,7 +88,8 @@ class ShellConnection {
   ~ShellConnection() {
     if (views::WindowManagerConnection::Exists())
       views::WindowManagerConnection::Reset();
-    base::WaitableEvent wait(false, false);
+    base::WaitableEvent wait(base::WaitableEvent::ResetPolicy::AUTOMATIC,
+                             base::WaitableEvent::InitialState::NOT_SIGNALED);
     thread_.task_runner()->PostTask(
         FROM_HERE, base::Bind(&ShellConnection::TearDownConnections,
                               base::Unretained(this), &wait));