Migrate WaitableEvent to enum-based constructor in ui/

ui/views/mus/views_mus_test_suite.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/mus/views_mus_test_suite.h"
 
 #include <memory>
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 49 matching lines @@
   if (!WindowManagerConnection::Exists())
     WindowManagerConnection::Create(connector, identity);
   return base::WrapUnique(new PlatformTestHelperMus);
 }
 
 }  // namespace
 
 class ShellConnection {
  public:
   ShellConnection() : thread_("Persistent shell connections") {
-    base::WaitableEvent wait(false, false);
+    base::WaitableEvent wait(base::WaitableEvent::ResetPolicy::AUTOMATIC,

[sky, 2016/06/01 19:18:35]

Did you consider making WaitableEvent take a bitmask of possible configurations
rather than two explicit policies? I suspect automatic and not-signaled are most
commonly used, so this code would become:

base::WaitableEvent event(base::WaitableEvent::DEFAULT);

Even better is to with a default value (which the style guide now allows) for
DEFAULT, so that this code becomes:

base::WaitableEvent event;

If you want to create manual, then it's:

event(base::WaitableEvent::MANUAL);

and if you want manual and signaled:

event(base::WaitableEvent::MANUAL | base::WaitableEvent::SIGNALED);

IMO this better matches how WaitableEvent is generally used and makes the api
nicer.

[gab, 2016/06/01 19:50:30]

Copied your suggestion on bug, danakj prefers the current API, please discuss it
there if you disagree.

+                             base::WaitableEvent::InitialState::NOT_SIGNALED);
     base::Thread::Options options;
     thread_.StartWithOptions(options);
     thread_.task_runner()->PostTask(
         FROM_HERE, base::Bind(&ShellConnection::SetUpConnections,
                               base::Unretained(this), &wait));
     wait.Wait();
 
     // WindowManagerConnection cannot be created from here yet, although the
     // connector and identity are available at this point. This is because
     // WindowManagerConnection needs a ViewsDelegate and a MessageLoop to have
     // been installed first. So delay the creation until the necessary
     // dependencies have been met.
     PlatformTestHelper::set_factory(base::Bind(
         &CreatePlatformTestHelper, shell_connector_.get(), shell_identity_));
   }
 
   ~ShellConnection() {
     if (views::WindowManagerConnection::Exists())
       views::WindowManagerConnection::Reset();
-    base::WaitableEvent wait(false, false);
+    base::WaitableEvent wait(base::WaitableEvent::ResetPolicy::AUTOMATIC,
+                             base::WaitableEvent::InitialState::NOT_SIGNALED);
     thread_.task_runner()->PostTask(
         FROM_HERE, base::Bind(&ShellConnection::TearDownConnections,
                               base::Unretained(this), &wait));
     wait.Wait();
   }
 
  private:
   void SetUpConnections(base::WaitableEvent* wait) {
     background_shell_.reset(new shell::BackgroundShell);
     background_shell_->Init(nullptr);
@@ skipping 49 matching lines @@
   ViewsTestSuite::Initialize();
   shell_connections_.reset(new ShellConnection);
 }
 
 void ViewsMusTestSuite::Shutdown() {
   shell_connections_.reset();
   ViewsTestSuite::Shutdown();
 }
 
 }  // namespace views