Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2027213002: Move (hopefully) remaining isolate related variables to toolchain.gypi (Closed)

Created:
4 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 6 months ago
Reviewers:
Michael Achenbach
CC:
Michael Achenbach, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move (hopefully) remaining isolate related variables to toolchain.gypi BUG=chromium:609107 R=machenbach@chromium.org Committed: https://crrev.com/a68a1eb38dda0a1eba3b7644a172d2f85e9c7abe Cr-Commit-Position: refs/heads/master@{#36664}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M gypfiles/standalone.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M gypfiles/toolchain.gypi View 2 chunks +15 lines, -0 lines 2 comments Download

Messages

Total messages: 10 (2 generated)
jochen (gone - plz use gerrit)
4 years, 6 months ago (2016-06-01 15:03:54 UTC) #1
Michael Achenbach
lgtm - you might also need to move jsfunfuzz variable? https://codereview.chromium.org/2027213002/diff/1/gypfiles/toolchain.gypi File gypfiles/toolchain.gypi (right): https://codereview.chromium.org/2027213002/diff/1/gypfiles/toolchain.gypi#newcode37 ...
4 years, 6 months ago (2016-06-02 06:46:03 UTC) #2
Michael Achenbach
On 2016/06/02 06:46:03, Michael Achenbach wrote: > lgtm - you might also need to move ...
4 years, 6 months ago (2016-06-02 06:47:47 UTC) #3
jochen (gone - plz use gerrit)
jsfunfuzz is not referenced from isolate.gypi, so I don't think it's needed https://codereview.chromium.org/2027213002/diff/1/gypfiles/toolchain.gypi File gypfiles/toolchain.gypi ...
4 years, 6 months ago (2016-06-02 06:48:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027213002/1
4 years, 6 months ago (2016-06-02 06:50:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 06:52:04 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a68a1eb38dda0a1eba3b7644a172d2f85e9c7abe Cr-Commit-Position: refs/heads/master@{#36664}
4 years, 6 months ago (2016-06-02 06:53:07 UTC) #9
Michael Achenbach
4 years, 6 months ago (2016-06-02 07:10:04 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2038463002/ by machenbach@chromium.org.

The reason for reverting is: Fails:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

Powered by Google App Engine
This is Rietveld 408576698