Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: gypfiles/toolchain.gypi

Issue 2027213002: Move (hopefully) remaining isolate related variables to toolchain.gypi (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gypfiles/standalone.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gypfiles/toolchain.gypi
diff --git a/gypfiles/toolchain.gypi b/gypfiles/toolchain.gypi
index f5f02899170b06ff1488660c4f5b91408921e314..1d4158c7cf58d16b8338ae549cd7ff17d731bbc6 100644
--- a/gypfiles/toolchain.gypi
+++ b/gypfiles/toolchain.gypi
@@ -29,6 +29,19 @@
{
'variables': {
+ 'variables': {
+ 'variables': {
+ # Instrument for code coverage and use coverage wrapper to exclude some
+ # files. Uses gcov if clang=0 is set explicitly. Otherwise,
+ # sanitizer_coverage must be set too.
+ 'coverage%': 0,
Michael Achenbach 2016/06/02 06:46:03 Did you remove this somewhere in return?
jochen (gone - plz use gerrit) 2016/06/02 06:48:39 it's also used in standalone.gypi directly, and th
+ },
+
+ 'coverage%': '<(coverage)',
+
+ # Check if valgrind directories are present.
+ 'has_valgrind%': '<!pymod_do_main(has_valgrind)',
+ },
'msvs_use_common_release': 0,
'clang%': 0,
'asan%': 0,
@@ -37,6 +50,8 @@
'tsan%': 0,
'ubsan%': 0,
'ubsan_vptr%': 0,
+ 'has_valgrind%': '<(has_valgrind)',
+ 'coverage%': '<(coverage)',
'v8_target_arch%': '<(target_arch)',
'v8_host_byteorder%': '<!(python -c "import sys; print sys.byteorder")',
# Native Client builds currently use the V8 ARM JIT and
« no previous file with comments | « gypfiles/standalone.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698