MacViews: Fix failing NativeWidgetMacTest.ChangeOpacity test.

MacViews: Fix failing NativeWidgetMacTest.ChangeOpacity test.

NativeWidgetMacTest.ChangeOpacity test regressed in crrev.com/2009333002. The
reason for the failure is that the expectation for [ns_window alphaValue] is a
double value, while Widget::SetOpacity(..) takes a float value. Changing the
expectation to a float literal fixes the test.

BUG=607403
Committed: https://crrev.com/60f03b5ff77766b46bbec2c564f3cee40fbe5968
Cr-Commit-Position: refs/heads/master@{#397318}

[karandeepb, 2016-06-02 00:03:55]

Description was changed from

==========
Fix NativeWidgetMacTest.ChangeOpacity
==========

to

==========
MacViews: Fix failing NativeWidgetMacTest.ChangeOpacity test.

NativeWidgetMacTest.ChangeOpacity test regressed in crrev.com/2009333002. The 
reason for the failure is that the expectation for [ns_window alphaValue] is a 
double value, while Widget::SetOpacity(..) takes a float value. Changing the 
expectation to a float literal fixes the test.

BUG=607403
==========

[karandeepb, 2016-06-02 00:05:13]

karandeepb@chromium.org changed reviewers:
+ tapted@chromium.org

[karandeepb, 2016-06-02 00:05:14]

PTAL Trent. Thanks.

[tapted, 2016-06-02 00:08:39]

lgtm

(also wow - EXPECT_DOUBLE_EQ has some epsilon check - it's bonkers that the
epsilon amount is too small to account for the float -> double conversion :/. 
There is EXPECT_FLOAT_EQ, but I think NSWindow alphaValue is double, so we'd
have the same problem). bleh/

[karandeepb, 2016-06-02 00:09:47]

On 2016/06/02 00:08:39, tapted wrote:
> lgtm
> 
> (also wow - EXPECT_DOUBLE_EQ has some epsilon check - it's bonkers that the
> epsilon amount is too small to account for the float -> double conversion :/. 
> There is EXPECT_FLOAT_EQ, but I think NSWindow alphaValue is double, so we'd
> have the same problem). bleh/

Yeah alphaValue is a CGFloat which can be a float/double depending on the
platform.

[karandeepb, 2016-06-02 00:10:13]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-06-02 00:11:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027143002/1

[commit-bot: I haz the power, 2016-06-02 02:23:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 02:23:17]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[karandeepb, 2016-06-02 02:46:39]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-06-02 02:47:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027143002/1

[commit-bot: I haz the power, 2016-06-02 03:48:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 03:48:14]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[karandeepb, 2016-06-02 05:55:43]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-06-02 05:56:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027143002/1

[commit-bot: I haz the power, 2016-06-02 06:42:27]

Description was changed from

==========
MacViews: Fix failing NativeWidgetMacTest.ChangeOpacity test.

NativeWidgetMacTest.ChangeOpacity test regressed in crrev.com/2009333002. The 
reason for the failure is that the expectation for [ns_window alphaValue] is a 
double value, while Widget::SetOpacity(..) takes a float value. Changing the 
expectation to a float literal fixes the test.

BUG=607403
==========

to

==========
MacViews: Fix failing NativeWidgetMacTest.ChangeOpacity test.

NativeWidgetMacTest.ChangeOpacity test regressed in crrev.com/2009333002. The 
reason for the failure is that the expectation for [ns_window alphaValue] is a 
double value, while Widget::SetOpacity(..) takes a float value. Changing the 
expectation to a float literal fixes the test.

BUG=607403
==========

[commit-bot: I haz the power, 2016-06-02 06:42:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-02 06:44:34]

Description was changed from

==========
MacViews: Fix failing NativeWidgetMacTest.ChangeOpacity test.

NativeWidgetMacTest.ChangeOpacity test regressed in crrev.com/2009333002. The 
reason for the failure is that the expectation for [ns_window alphaValue] is a 
double value, while Widget::SetOpacity(..) takes a float value. Changing the 
expectation to a float literal fixes the test.

BUG=607403
==========

to

==========
MacViews: Fix failing NativeWidgetMacTest.ChangeOpacity test.

NativeWidgetMacTest.ChangeOpacity test regressed in crrev.com/2009333002. The
reason for the failure is that the expectation for [ns_window alphaValue] is a
double value, while Widget::SetOpacity(..) takes a float value. Changing the
expectation to a float literal fixes the test.

BUG=607403

Committed: https://crrev.com/60f03b5ff77766b46bbec2c564f3cee40fbe5968
Cr-Commit-Position: refs/heads/master@{#397318}
==========

[commit-bot: I haz the power, 2016-06-02 06:44:35]

Patchset 1 (id:??) landed as
https://crrev.com/60f03b5ff77766b46bbec2c564f3cee40fbe5968
Cr-Commit-Position: refs/heads/master@{#397318}