ui/views/widget/native_widget_mac_unittest.mm - Issue 2027143002: MacViews: Fix failing NativeWidgetMacTest.ChangeOpacity test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/native_widget_mac_unittest.mm

Issue 2027143002: MacViews: Fix failing NativeWidgetMacTest.ChangeOpacity test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/widget/native_widget_mac_unittest.mm

diff --git a/ui/views/widget/native_widget_mac_unittest.mm b/ui/views/widget/native_widget_mac_unittest.mm

index 511a507bab50b1c701ebbd5da5be933a2e20240c..13d6e16c391c62136f8b8c5fa6727742478d0b67 100644

--- a/ui/views/widget/native_widget_mac_unittest.mm

+++ b/ui/views/widget/native_widget_mac_unittest.mm

@@ -1261,7 +1261,7 @@ TEST_F(NativeWidgetMacTest, ChangeOpacity) {

CGFloat old_opacity = [ns_window alphaValue];

widget->SetOpacity(.7f);

EXPECT_NE(old_opacity, [ns_window alphaValue]);

- EXPECT_DOUBLE_EQ(.7, [ns_window alphaValue]);

+ EXPECT_DOUBLE_EQ(.7f, [ns_window alphaValue]);

widget->CloseNow();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »