ARC IME: Ignore InsertChar events while text input type is NONE.

ARC IME: Ignore InsertChar events while text input type is NONE.

The method is clearly documented to be called regardless of the input type,
but for our purpose, it is needed only when the client is really requiring
text input.

BUG=b/28930470

Committed: https://crrev.com/4bffedbdfc887948e739bf1318036035c52897f0
Cr-Commit-Position: refs/heads/master@{#397088}

[kinaba, 2016-06-01 06:59:53]

Patchset #1 (id:1) has been deleted

[kinaba, 2016-06-01 07:01:55]

Patchset #1 (id:20001) has been deleted

[kinaba, 2016-06-01 07:23:03]

Patchset #1 (id:40001) has been deleted

[kinaba, 2016-06-01 07:41:04]

kinaba@chromium.org changed reviewers:
+ hidehiko@chromium.org

[kinaba, 2016-06-01 07:41:04]

PTAL

[hidehiko, 2016-06-01 07:53:38]

lgtm

https://codereview.chromium.org/2027123002/diff/60001/components/arc/ime/arc_...
File components/arc/ime/arc_ime_service_unittest.cc (right):

https://codereview.chromium.org/2027123002/diff/60001/components/arc/ime/arc_...
components/arc/ime/arc_ime_service_unittest.cc:104:
fake_arc_bridge_service_.reset();
Set fake_arc_ime_bridge_ to nullptr, just in case?

[kinaba, 2016-06-01 07:56:15]

https://codereview.chromium.org/2027123002/diff/60001/components/arc/ime/arc_...
File components/arc/ime/arc_ime_service_unittest.cc (right):

https://codereview.chromium.org/2027123002/diff/60001/components/arc/ime/arc_...
components/arc/ime/arc_ime_service_unittest.cc:104:
fake_arc_bridge_service_.reset();
On 2016/06/01 07:53:38, hidehiko wrote:
> Set fake_arc_ime_bridge_ to nullptr, just in case?

Done.

[kinaba, 2016-06-01 08:00:37]

The CQ bit was checked by kinaba@chromium.org

[kinaba, 2016-06-01 08:00:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org
Link to the patchset: https://codereview.chromium.org/2027123002/#ps80001
(title: "Addressed review #6")

[commit-bot: I haz the power, 2016-06-01 08:00:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027123002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027123002/80001

[commit-bot: I haz the power, 2016-06-01 09:07:39]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-06-01 09:13:06]

Description was changed from

==========
ARC IME: Ignore InsertChar events while text input type is NONE.

The method is clearly documented to be called regardless of the input type,
but for our purpose, it is needed only when the client is really requiring
text input.

BUG=b/28930470
==========

to

==========
ARC IME: Ignore InsertChar events while text input type is NONE.

The method is clearly documented to be called regardless of the input type,
but for our purpose, it is needed only when the client is really requiring
text input.

BUG=b/28930470

Committed: https://crrev.com/4bffedbdfc887948e739bf1318036035c52897f0
Cr-Commit-Position: refs/heads/master@{#397088}
==========

[commit-bot: I haz the power, 2016-06-01 09:13:07]

Patchset 2 (id:??) landed as
https://crrev.com/4bffedbdfc887948e739bf1318036035c52897f0
Cr-Commit-Position: refs/heads/master@{#397088}