ARC IME: Ignore InsertChar events while text input type is NONE.

components/arc/ime/arc_ime_service.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/ime/arc_ime_service.h"
 
 #include "base/logging.h"
 #include "components/arc/ime/arc_ime_bridge_impl.h"
 #include "components/exo/shell_surface.h"
 #include "components/exo/surface.h"
@@ skipping 170 matching lines @@
     ime_bridge_->SendInsertText(base::string16());
   }
 }
 
 void ArcImeService::InsertText(const base::string16& text) {
   has_composition_text_ = false;
   ime_bridge_->SendInsertText(text);
 }
 
 void ArcImeService::InsertChar(const ui::KeyEvent& event) {
+  // According to the document in text_input_client.h, InsertChar() is called
+  // even when the text input type is NONE. We ignore such events, since for
+  // ARC we are only interested in the event as a method of text input.
+  if (ime_type_ == ui::TEXT_INPUT_TYPE_NONE)
+    return;
+
   // Drop 0x00-0x1f (C0 controls), 0x7f (DEL), and 0x80-0x9f (C1 controls).
   // See: https://en.wikipedia.org/wiki/Unicode_control_characters
   // They are control characters and not treated as a text insertion.
   const base::char16 ch = event.GetCharacter();
   const bool is_control_char = (0x00 <= ch && ch <= 0x1f) ||
                                (0x7f <= ch && ch <= 0x9f);
 
   if (!is_control_char && !ui::IsSystemKeyModifier(event.flags())) {
     has_composition_text_ = false;
     ime_bridge_->SendInsertText(base::string16(1, event.GetText()));
@@ skipping 72 matching lines @@
 bool ArcImeService::ChangeTextDirectionAndLayoutAlignment(
     base::i18n::TextDirection direction) {
   return false;
 }
 
 bool ArcImeService::IsEditCommandEnabled(int command_id) {
   return false;
 }
 
 }  // namespace arc