Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2027113003: binding: Makes PrivateScriptRunner use V8PrivateProperty instead of V8HiddenValue. (Closed)

Created:
4 years, 6 months ago by Yuki
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Makes PrivateScriptRunner use V8PrivateProperty instead of V8HiddenValue. This CL adds a new API, V8PrivateProperty::hasValue(). BUG= Committed: https://crrev.com/3bbecbf67d09869546cf44fc69a74043cb7dd2ec Cr-Commit-Position: refs/heads/master@{#397107}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -28 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp View 1 2 chunks +27 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Yuki
Could you review this CL?
4 years, 6 months ago (2016-06-01 09:41:56 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-01 11:07:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027113003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027113003/20001
4 years, 6 months ago (2016-06-01 11:39:58 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 11:43:39 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 11:45:20 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3bbecbf67d09869546cf44fc69a74043cb7dd2ec
Cr-Commit-Position: refs/heads/master@{#397107}

Powered by Google App Engine
This is Rietveld 408576698