Relax checks added in commit 8f3a311.

Relax checks added in commit 8f3a311.

Some shading types do not use these fields.

Committed: https://pdfium.googlesource.com/pdfium/+/c3246466df915a5b8a639dd3a611d18cd106773b

[Lei Zhang, 2016-06-01 00:17:22]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Lei Zhang, 2016-06-01 00:17:22]

And then I worry the previous CL is being too strict.

[Tom Sepez, 2016-06-01 19:28:19]

lgtm

https://codereview.chromium.org/2027053002/diff/20001/core/fpdfapi/fpdf_page/...
File core/fpdfapi/fpdf_page/cpdf_meshstream.h (right):

https://codereview.chromium.org/2027053002/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/cpdf_meshstream.h:54: static const uint32_t kMaxComps =
8;
nit: kMaxComponents

[Lei Zhang, 2016-06-01 19:33:32]

On 2016/06/01 19:28:19, Tom Sepez wrote:
> lgtm
> 
>
https://codereview.chromium.org/2027053002/diff/20001/core/fpdfapi/fpdf_page/...
> File core/fpdfapi/fpdf_page/cpdf_meshstream.h (right):
> 
>
https://codereview.chromium.org/2027053002/diff/20001/core/fpdfapi/fpdf_page/...
> core/fpdfapi/fpdf_page/cpdf_meshstream.h:54: static const uint32_t kMaxComps =
> 8;
> nit: kMaxComponents

Will do. https://codereview.chromium.org/2020183004 needs reviewing before this.

[Lei Zhang, 2016-06-01 19:42:34]

https://codereview.chromium.org/2027053002/diff/20001/core/fpdfapi/fpdf_page/...
File core/fpdfapi/fpdf_page/cpdf_meshstream.h (right):

https://codereview.chromium.org/2027053002/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/cpdf_meshstream.h:54: static const uint32_t kMaxComps =
8;
On 2016/06/01 19:28:19, Tom Sepez wrote:
> nit: kMaxComponents

Done. I changed all the other uses for consistency.

[Lei Zhang, 2016-06-01 20:48:51]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-06-01 20:48:52]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2027053002/#ps40001
(title: "components")

[commit-bot: I haz the power, 2016-06-01 20:48:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027053002/40001

[commit-bot: I haz the power, 2016-06-01 20:49:07]

Description was changed from

==========
Relax checks added in commit 8f3a311.

Some shading types do not use these fields.
==========

to

==========
Relax checks added in commit 8f3a311.

Some shading types do not use these fields.

Committed:
https://pdfium.googlesource.com/pdfium/+/c3246466df915a5b8a639dd3a611d18cd106...
==========

[commit-bot: I haz the power, 2016-06-01 20:49:08]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/c3246466df915a5b8a639dd3a611d18cd106...