Remove FXJSE_Value_ToObject and call methods directly

xfa/fxjse/value.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef XFA_FXJSE_VALUE_H_
 #define XFA_FXJSE_VALUE_H_
 
 #include "xfa/fxjse/scope_inline.h"
 
+class CXFA_FM2JSContext;
+class CXFA_Node;
+class CXFA_Object;
+class CXFA_ThisProxy;
+
 class CFXJSE_Value {
  public:
   CFXJSE_Value(v8::Isolate* pIsolate) : m_pIsolate(pIsolate) {}
 
   V8_INLINE FX_BOOL IsUndefined() const {
     if (m_hValue.IsEmpty()) {
       return FALSE;
     }
     CFXJSE_ScopeUtil_IsolateHandle scope(m_pIsolate);
     v8::Local<v8::Value> hValue =
@@ skipping 112 matching lines @@
   }
   V8_INLINE void ToString(CFX_ByteString& szStrOutput) const {
     ASSERT(!m_hValue.IsEmpty());
     CFXJSE_ScopeUtil_IsolateHandleRootContext scope(m_pIsolate);
     v8::Local<v8::Value> hValue =
         v8::Local<v8::Value>::New(m_pIsolate, m_hValue);
     v8::Local<v8::String> hString = hValue->ToString();
     v8::String::Utf8Value hStringVal(hString);
     szStrOutput = *hStringVal;
   }
-  CFXJSE_HostObject* ToObject(CFXJSE_Class* lpClass) const;
+  CFXJSE_HostObject* ToHostObject(CFXJSE_Class* lpClass) const;
+  CXFA_Object* ToObject(CFXJSE_Class* lpClass) const;

[Tom Sepez, 2016/06/01 20:17:58]

Layering violation.  I think you're stuck with ToHostObject() in this layer. 
You can make a helper function to do the other casts in the file where they are
used.

[dsinclair, 2016/06/01 20:34:31]

Why is this a violation? CXFA_Object is defined in xfa/fxfa/parser which is all
under the xfa/ tree so it should be accessible from here.

+  CXFA_Node* ToNode(CFXJSE_Class* lpClass) const;
+  CXFA_FM2JSContext* ToJSContext(CFXJSE_Class* lpClass) const;
+  CXFA_ThisProxy* ToProxy(CFXJSE_Class* lpClass) const;
 
   V8_INLINE void SetUndefined() {
     CFXJSE_ScopeUtil_IsolateHandle scope(m_pIsolate);
     v8::Local<v8::Value> hValue = v8::Undefined(m_pIsolate);
     m_hValue.Reset(m_pIsolate, hValue);
   }
   V8_INLINE void SetNull() {
     CFXJSE_ScopeUtil_IsolateHandle scope(m_pIsolate);
     v8::Local<v8::Value> hValue = v8::Null(m_pIsolate);
     m_hValue.Reset(m_pIsolate, hValue);
@@ skipping 69 matching lines @@
 
   CFXJSE_Value();
   CFXJSE_Value(const CFXJSE_Value&);
   CFXJSE_Value& operator=(const CFXJSE_Value&);
 
   v8::Isolate* m_pIsolate;
   v8::Global<v8::Value> m_hValue;
 };
 
 #endif  // XFA_FXJSE_VALUE_H_