Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2026953003: gn: Build angle_end2end_tests again. (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Build angle_end2end_tests again. The prerequisite for doing this TODO has been done long ago. BUG=531296 Committed: https://crrev.com/72c2da2da345742bba337aecc20c5fd3c6455f39 Cr-Commit-Position: refs/heads/master@{#397037}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -6 lines 3 comments Download

Messages

Total messages: 11 (3 generated)
Nico
4 years, 6 months ago (2016-05-31 22:20:03 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/2026953003/diff/20001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2026953003/diff/20001/BUILD.gn#newcode483 BUILD.gn:483: "//third_party/angle/src/tests:angle_end2end_tests", so, this adds linux (but not cros, ...
4 years, 6 months ago (2016-05-31 22:46:29 UTC) #3
Nico
Thanks! https://codereview.chromium.org/2026953003/diff/20001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2026953003/diff/20001/BUILD.gn#newcode483 BUILD.gn:483: "//third_party/angle/src/tests:angle_end2end_tests", On 2016/05/31 22:46:28, Dirk Pranke (slow) wrote: ...
4 years, 6 months ago (2016-05-31 23:24:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026953003/20001
4 years, 6 months ago (2016-05-31 23:24:56 UTC) #6
Dirk Pranke
https://codereview.chromium.org/2026953003/diff/20001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2026953003/diff/20001/BUILD.gn#newcode483 BUILD.gn:483: "//third_party/angle/src/tests:angle_end2end_tests", On 2016/05/31 23:24:05, Nico wrote: > On 2016/05/31 ...
4 years, 6 months ago (2016-05-31 23:25:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 03:12:06 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/72c2da2da345742bba337aecc20c5fd3c6455f39 Cr-Commit-Position: refs/heads/master@{#397037}
4 years, 6 months ago (2016-06-01 03:13:39 UTC) #10
Nico
4 years, 6 months ago (2016-06-01 15:00:01 UTC) #11
Message was sent while issue was closed. 
On 2016/05/31 23:25:53, Dirk Pranke wrote:
> https://codereview.chromium.org/2026953003/diff/20001/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/2026953003/diff/20001/BUILD.gn#newcode483
> BUILD.gn:483: "//third_party/angle/src/tests:angle_end2end_tests",
> On 2016/05/31 23:24:05, Nico wrote:
> > On 2016/05/31 22:46:28, Dirk Pranke (slow) wrote:
> > > so, this adds linux (but not cros, and win was already building), right?
> > 
> > Yes. Should they build on Android too?
> 
> I do not know.

Looks like we don't build it on Android in gyp:
https://code.google.com/p/chromium/codesearch#chromium/src/gpu/gpu.gyp&l=1026

Powered by Google App Engine
This is Rietveld 408576698