Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: BUILD.gn

Issue 2026953003: gn: Build angle_end2end_tests again. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 5e9ba95ee6764ee21c65f271f0a1eb1dfcf97e07..af95da2457004df1b743455fc76281162c90ac1b 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -480,16 +480,11 @@ group("both_gn_and_gyp") {
"//net:tld_cleanup",
"//ppapi:pepper_hash_for_uma",
"//ppapi:ppapi_perftests",
+ "//third_party/angle/src/tests:angle_end2end_tests",
Dirk Pranke 2016/05/31 22:46:28 so, this adds linux (but not cros, and win was alr
Nico 2016/05/31 23:24:05 Yes. Should they build on Android too?
Dirk Pranke 2016/05/31 23:25:53 I do not know.
"//third_party/leveldatabase:env_chromium_unittests",
"//third_party/libaddressinput:libaddressinput_unittests",
]
}
- if (!is_android && !is_linux) {
- # TODO(dpranke): Re-enable this once
- # https://chromium-review.googlesource.com/#/c/312298/1 is rolled
- # into chromium.
- deps += [ "//third_party/angle/src/tests:angle_end2end_tests" ]
- }
if (enable_extensions) {
deps += [ "//extensions/shell:app_shell" ]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698