Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2026913002: Add a comment to ActivityName::activity_name. (Closed)

Created:
4 years, 6 months ago by Yusuke Sato
Modified:
4 years, 6 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a comment to ActivityName::activity_name. This reflects the change in ag/1087804. BUG=616159 Committed: https://crrev.com/46a8fa93b2dd79ecbd9435917641b3103e764892 Cr-Commit-Position: refs/heads/master@{#396947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M components/arc/intent_helper/activity_icon_loader.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yusuke Sato
PTAL too
4 years, 6 months ago (2016-05-31 21:21:06 UTC) #2
Luis Héctor Chávez
lgtm
4 years, 6 months ago (2016-05-31 21:37:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026913002/1
4 years, 6 months ago (2016-05-31 21:50:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 22:13:12 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 22:15:37 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/46a8fa93b2dd79ecbd9435917641b3103e764892
Cr-Commit-Position: refs/heads/master@{#396947}

Powered by Google App Engine
This is Rietveld 408576698