Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: components/arc/intent_helper/activity_icon_loader.h

Issue 2026913002: Add a comment to ActivityName::activity_name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/intent_helper/activity_icon_loader.h
diff --git a/components/arc/intent_helper/activity_icon_loader.h b/components/arc/intent_helper/activity_icon_loader.h
index f66ec30c68427fc93f6fac01319701bbef9824b0..41d2ace9640a7a63f950b7199d965c3ce36fb3a2 100644
--- a/components/arc/intent_helper/activity_icon_loader.h
+++ b/components/arc/intent_helper/activity_icon_loader.h
@@ -34,9 +34,13 @@ class ActivityIconLoader : public base::RefCounted<ActivityIconLoader> {
ActivityName(const std::string& package_name,
const std::string& activity_name);
bool operator<(const ActivityName& other) const;
+
// TODO(yusukes): Add const to these variables later. At this point,
// doing so seems to confuse g++ 4.6 on builders.
std::string package_name;
+
+ // Can be empty. When |activity_name| is empty, the loader tries to fetch
+ // the package's default icon.
std::string activity_name;
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698