Issue 2026903002: Update iOS WebUI History to use icon.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2026903002: Update iOS WebUI History to use icon.js (Closed)

Created:
4 years, 6 months ago by Jackie Quinn

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Update iOS WebUI History to use icon.js Use icon.js in iOS WebUI History, which was factored out of util.js in https://codereview.chromium.org/1919183005 BUG=614871 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2014743002 Cr-Commit-Position: refs/heads/master@{#396283} (cherry picked from commit cd199135e935f3c9ce7be0e9954382ab0d2140e9) Committed: https://chromium.googlesource.com/chromium/src/+/f57aff4a7a0e2799360cfde196eb84c62fefe7ae

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -3 lines)			Patch
M	ios/chrome/app/resources/history/history.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ios/chrome/app/resources/history/history.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ios/chrome/app/resources/history/other_devices.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ios/web/webui/resources/web_ui_favicons.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/webui/resources/js/icon.js	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Jackie Quinn

4 years, 6 months ago (2016-05-31 20:56:08 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f57aff4a7a0e2799360cfde196eb84c62fefe7ae.