Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2014743002: Update iOS WebUI History to use icon.js (Closed)

Created:
4 years, 7 months ago by Jackie Quinn
Modified:
4 years, 6 months ago
Reviewers:
sdefresne, dpapad
CC:
chromium-reviews, oshima+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update iOS WebUI History to use icon.js Use icon.js in iOS WebUI History, which was factored out of util.js in https://codereview.chromium.org/1919183005 BUG=614871 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/cd199135e935f3c9ce7be0e9954382ab0d2140e9 Cr-Commit-Position: refs/heads/master@{#396283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ios/chrome/app/resources/history/history.html View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/app/resources/history/history.js View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/app/resources/history/other_devices.js View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/resources/web_ui_favicons.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/icon.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Jackie Quinn
4 years, 7 months ago (2016-05-26 00:01:47 UTC) #3
dpapad
LGTM. So there are no tests for IOS History WebUI? This will happen again most ...
4 years, 7 months ago (2016-05-26 00:09:28 UTC) #4
sdefresne
On 2016/05/26 at 00:09:28, dpapad wrote: > LGTM. > > So there are no tests ...
4 years, 7 months ago (2016-05-26 06:14:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014743002/1
4 years, 7 months ago (2016-05-26 20:05:04 UTC) #7
Jackie Quinn
On 2016/05/26 06:14:35, sdefresne wrote: > On 2016/05/26 at 00:09:28, dpapad wrote: > > LGTM. ...
4 years, 7 months ago (2016-05-26 20:05:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-26 21:15:40 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 21:17:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd199135e935f3c9ce7be0e9954382ab0d2140e9
Cr-Commit-Position: refs/heads/master@{#396283}

Powered by Google App Engine
This is Rietveld 408576698