Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Unified Diff: third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h

Issue 2026803002: Avoid GPU readback in tex(Sub)Image2D(ImageBitmap) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address kbr@'s comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h
diff --git a/third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h b/third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h
index 001e3b01b93b3145e6792ca8fc9bc93c112ef843..a166152aa58541840bc7ccb36e22e6ecd685cbe4 100644
--- a/third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h
+++ b/third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h
@@ -7,9 +7,12 @@
#include "platform/graphics/Image.h"
#include "public/platform/WebExternalTextureMailbox.h"
+#include "third_party/khronos/GLES2/gl2.h"
namespace blink {
+class WebGraphicsContext3DProvider;
+
class PLATFORM_EXPORT StaticBitmapImage final : public Image {
public:
~StaticBitmapImage() override;
@@ -29,10 +32,19 @@ public:
void setOriginClean(bool flag) { m_isOriginClean = flag; }
bool isPremultiplied() const { return m_isPremultiplied; }
void setPremultiplied(bool flag) { m_isPremultiplied = flag; }
+ void copyToTexture(WebGraphicsContext3DProvider*, GLuint, GLenum, GLenum, bool);
+ bool isTextureBacked() override;
+ bool hasMailbox() { return m_mailbox.textureSize.width != 0 && m_mailbox.textureSize.height != 0; }
+
protected:
StaticBitmapImage(PassRefPtr<SkImage>);
StaticBitmapImage(WebExternalTextureMailbox&);
+private:
+ GLuint switchStorageToSkImage(WebGraphicsContext3DProvider*);
+ bool switchStorageToMailbox(WebGraphicsContext3DProvider*);
+ GLuint textureIdForWebGL(WebGraphicsContext3DProvider*);
+
RefPtr<SkImage> m_image;
WebExternalTextureMailbox m_mailbox;
bool m_isOriginClean = true;

Powered by Google App Engine
This is Rietveld 408576698