Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2026673003: Add Document encoding to header preloaded requests (Closed)

Created:
4 years, 6 months ago by Yoav Weiss
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Add Document encoding to header preloaded requests When resources were preloaded using Link: headers, they weren't requested with the document's charset, and therefore their decoding might have differed from non-preloaded resources. This CL fixes that by requesting them with the right encoding. BUG=615307 Review-Url: https://codereview.chromium.org/2019303002 Cr-Commit-Position: refs/heads/master@{#396735} (cherry picked from commit 727d4183ad164bd4eaa4bde1c82eadb592e1c41c) Committed: https://chromium.googlesource.com/chromium/src/+/c732f3b13215ca042376f72e361d8a140ea81802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/http/tests/preload/link_preload_charset.php View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/preload/resources/charset.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Yoav Weiss
4 years, 6 months ago (2016-05-31 21:26:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c732f3b13215ca042376f72e361d8a140ea81802.

Powered by Google App Engine
This is Rietveld 408576698