Add Document encoding to header preloaded requests

Add Document encoding to header preloaded requests

When resources were preloaded using Link: headers, they weren't requested with
the document's charset, and therefore their decoding might have differed from non-preloaded resources.
This CL fixes that by requesting them with the right encoding.

BUG=615307
Committed: https://crrev.com/727d4183ad164bd4eaa4bde1c82eadb592e1c41c
Cr-Commit-Position: refs/heads/master@{#396735}

[Yoav Weiss, 2016-05-30 09:15:41]

yoav@yoav.ws changed reviewers:
+ japhet@chromium.org, mkwst@chromium.org

[Yoav Weiss, 2016-05-30 09:15:42]

Hey Mike & Nate,

Turns out that resource preloaded using headers weren't getting set with the
document's charset, so their decoding may have differed from what it should have
been.

I've fixed that by adding the Document's charset encoding as part of their
requests.

Can you take a look?

[Mike West, 2016-05-30 10:59:55]

Code looks fine! LGTM!

I have no idea how the test works. Halp!

https://codereview.chromium.org/2019303002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/preload/resources/charset.js
(right):

https://codereview.chromium.org/2019303002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/preload/resources/charset.js:1:
window.preload_header = 'Кириллиця';
How does this actually test what you want to test? Sorry, I'm not up enough on
encoding to actually understand what's going on here. :)

[Yoav Weiss, 2016-05-30 11:02:44]

https://codereview.chromium.org/2019303002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/preload/resources/charset.js
(right):

https://codereview.chromium.org/2019303002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/preload/resources/charset.js:1:
window.preload_header = 'Кириллиця';
On 2016/05/30 10:59:55, Mike West (OOO until 30th) wrote:
> How does this actually test what you want to test? Sorry, I'm not up enough on
> encoding to actually understand what's going on here. :)

The JS set the string according to the JS's encoding. The string is then
compared to the same string under the Document's encoding.
If both are decoded as UTF-8, strings match and everyone's happy. If the JS's
encoding was off and it was decoded using the wrong charset, the test fails.

[Yoav Weiss, 2016-05-30 15:47:58]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2016-05-30 15:48:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2019303002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2019303002/1

[commit-bot: I haz the power, 2016-05-30 15:51:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-30 15:52:52]

Description was changed from

==========
Add Document encoding to header preloaded requests

When resources were preloaded using Link: headers, they weren't requested with
the document's charset, and therefore their decoding might have differed from
non-preloaded resources.
This CL fixes that by requesting them with the right encoding.

BUG=615307
==========

to

==========
Add Document encoding to header preloaded requests

When resources were preloaded using Link: headers, they weren't requested with
the document's charset, and therefore their decoding might have differed from
non-preloaded resources.
This CL fixes that by requesting them with the right encoding.

BUG=615307

Committed: https://crrev.com/727d4183ad164bd4eaa4bde1c82eadb592e1c41c
Cr-Commit-Position: refs/heads/master@{#396735}
==========

[commit-bot: I haz the power, 2016-05-30 15:52:53]

Patchset 1 (id:??) landed as
https://crrev.com/727d4183ad164bd4eaa4bde1c82eadb592e1c41c
Cr-Commit-Position: refs/heads/master@{#396735}