Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2026633004: [x64] Fix invalid REX prefix for pslld, psrld and friends. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Fix invalid REX prefix for pslld, psrld and friends. R=epertoso@chromium.org Committed: https://crrev.com/f2c0264a0a4586f07c69b909583c4456176008b8 Cr-Commit-Position: refs/heads/master@{#36631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M src/x64/assembler-x64-inl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-01 07:28:57 UTC) #1
epertoso
lgtm
4 years, 6 months ago (2016-06-01 07:51:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026633004/1
4 years, 6 months ago (2016-06-01 07:57:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 07:59:31 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 08:00:09 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f2c0264a0a4586f07c69b909583c4456176008b8
Cr-Commit-Position: refs/heads/master@{#36631}

Powered by Google App Engine
This is Rietveld 408576698