src/x64/assembler-x64-inl.h - Issue 2026633004: [x64] Fix invalid REX prefix for pslld, psrld and friends.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64-inl.h

Issue 2026633004: [x64] Fix invalid REX prefix for pslld, psrld and friends. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/assembler-x64-inl.h

diff --git a/src/x64/assembler-x64-inl.h b/src/x64/assembler-x64-inl.h

index 4fc9f8b544fa7853d8f7629a393aef1cfcbe5bf5..60acacd3bbb6417f8bc2b3d1a39edd839a285c19 100644

--- a/src/x64/assembler-x64-inl.h

+++ b/src/x64/assembler-x64-inl.h

@@ -179,9 +179,8 @@ void Assembler::emit_optional_rex_32(Register rm_reg) {

if (rm_reg.high_bit()) emit(0x41);

}

-void Assembler::emit_optional_rex_32(XMMRegister reg) {

- byte rex_bits = (reg.code() & 0x8) >> 1;

- if (rex_bits != 0) emit(0x40 | rex_bits);

+void Assembler::emit_optional_rex_32(XMMRegister rm_reg) {

+ if (rm_reg.high_bit()) emit(0x41);

}

void Assembler::emit_optional_rex_32(const Operand& op) {

« no previous file with comments | « no previous file | test/cctest/test-assembler-x64.cc » ('j') | no next file with comments »