Remove limit on individual hpack string literals.

Remove limit on individual hpack string literals.

We obviously want to bound the memory usage of hpack. http2 has an in-protocol
mechanism for this: send SETTINGS_MAX_HEADER_LIST_SIZE to the peer with a
suitable value. With the default 16 KB limit on header list size, the limit
removed by this CL is redundant. If we ever increased the
SETTINGS_MAX_HEADER_LIST_SIZE value then we are still limited to whatever we
set that to.

This CL lands server change 123307298 by rjshade.

BUG=488484
Committed: https://crrev.com/dcc95a083eb44685b7b2566a8b00602dd1e7e299
Cr-Commit-Position: refs/heads/master@{#400716}

[yinjie, 2016-05-30 18:11:06]

The CQ bit was checked by yinjie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-30 18:11:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026593002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026593002/1

[commit-bot: I haz the power, 2016-05-30 20:06:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-30 20:06:05]

Dry run: This issue passed the CQ dry run.

[yinjie, 2016-05-30 20:06:22]

yinjie@chromium.org changed reviewers:
+ bnc@chromium.org

[Bence, 2016-05-31 19:49:10]

On 2016/05/30 20:06:23, yinjie wrote:

Please also remove HpackDecoder::max_string_literal_size_ and
HpackInputStream::max_string_literal_size_ members.

[yinjie, 2016-06-16 01:32:26]

The CQ bit was checked by yinjie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 01:33:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026593002/20001

[commit-bot: I haz the power, 2016-06-16 02:36:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 02:36:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[yinjie, 2016-06-17 22:35:07]

The CQ bit was checked by yinjie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 22:35:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026593002/40001

[commit-bot: I haz the power, 2016-06-17 23:40:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 23:40:35]

Dry run: This issue passed the CQ dry run.

[yinjie, 2016-06-17 23:41:37]

On 2016/06/17 23:40:35, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Those members are removed. Please take a look. Thanks!

[Bence, 2016-06-20 12:02:36]

LGTM with nit.  Thank you.

https://codereview.chromium.org/2026593002/diff/40001/net/spdy/hpack/hpack_hu...
File net/spdy/hpack/hpack_huffman_table_test.cc (right):

https://codereview.chromium.org/2026593002/diff/40001/net/spdy/hpack/hpack_hu...
net/spdy/hpack/hpack_huffman_table_test.cc:10: #include <limits>
Please remove this include: it seems like all std::numeric_limits<> instances
are removed from this file.

[yinjie, 2016-06-20 16:17:44]

The CQ bit was checked by yinjie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-20 16:17:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026593002/60001

[commit-bot: I haz the power, 2016-06-20 17:36:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 17:36:10]

Dry run: This issue passed the CQ dry run.

[yinjie, 2016-06-20 17:37:32]

On 2016/06/20 12:02:36, Bence wrote:
> LGTM with nit.  Thank you.
> 
>
https://codereview.chromium.org/2026593002/diff/40001/net/spdy/hpack/hpack_hu...
> File net/spdy/hpack/hpack_huffman_table_test.cc (right):
> 
>
https://codereview.chromium.org/2026593002/diff/40001/net/spdy/hpack/hpack_hu...
> net/spdy/hpack/hpack_huffman_table_test.cc:10: #include <limits>
> Please remove this include: it seems like all std::numeric_limits<> instances
> are removed from this file.

Thanks for the review!

[yinjie, 2016-06-20 17:37:43]

The CQ bit was checked by yinjie@chromium.org

[yinjie, 2016-06-20 17:37:43]

The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org
Link to the patchset: https://codereview.chromium.org/2026593002/#ps60001
(title: "Remove unused include.")

[commit-bot: I haz the power, 2016-06-20 17:38:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026593002/60001

[commit-bot: I haz the power, 2016-06-20 17:43:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-20 17:53:45]

Description was changed from

==========
Remove limit on individual hpack string literals.

We obviously want to bound the memory usage of hpack. http2 has an in-protocol
mechanism for this: send SETTINGS_MAX_HEADER_LIST_SIZE to the peer with a
suitable value. With the default 16 KB limit on header list size, the limit
removed by this CL is redundant. If we ever increased the
SETTINGS_MAX_HEADER_LIST_SIZE value then we are still limited to whatever we
set that to.

This CL lands server change 123307298 by rjshade.

BUG=488484
==========

to

==========
Remove limit on individual hpack string literals.

We obviously want to bound the memory usage of hpack. http2 has an in-protocol
mechanism for this: send SETTINGS_MAX_HEADER_LIST_SIZE to the peer with a
suitable value. With the default 16 KB limit on header list size, the limit
removed by this CL is redundant. If we ever increased the
SETTINGS_MAX_HEADER_LIST_SIZE value then we are still limited to whatever we
set that to.

This CL lands server change 123307298 by rjshade.

BUG=488484

Committed: https://crrev.com/dcc95a083eb44685b7b2566a8b00602dd1e7e299
Cr-Commit-Position: refs/heads/master@{#400716}
==========

[commit-bot: I haz the power, 2016-06-20 17:53:46]

Patchset 4 (id:??) landed as
https://crrev.com/dcc95a083eb44685b7b2566a8b00602dd1e7e299
Cr-Commit-Position: refs/heads/master@{#400716}