Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1702)

Unified Diff: net/spdy/hpack/hpack_input_stream.cc

Issue 2026593002: Remove limit on individual hpack string literals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused include. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/hpack/hpack_input_stream.h ('k') | net/spdy/hpack/hpack_input_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/hpack/hpack_input_stream.cc
diff --git a/net/spdy/hpack/hpack_input_stream.cc b/net/spdy/hpack/hpack_input_stream.cc
index 79455e51fe7f02f62949e204c5d05534b2cfbfef..751f6c64d0e54c8385b941a871a6a8c17f9e8a83 100644
--- a/net/spdy/hpack/hpack_input_stream.cc
+++ b/net/spdy/hpack/hpack_input_stream.cc
@@ -15,10 +15,8 @@ namespace net {
using base::StringPiece;
using std::string;
-HpackInputStream::HpackInputStream(uint32_t max_string_literal_size,
- StringPiece buffer)
- : max_string_literal_size_(max_string_literal_size),
- buffer_(buffer),
+HpackInputStream::HpackInputStream(StringPiece buffer)
+ : buffer_(buffer),
bit_offset_(0),
parsed_bytes_(0),
parsed_bytes_current_(0),
@@ -127,10 +125,6 @@ bool HpackInputStream::DecodeNextIdentityString(StringPiece* str) {
return false;
}
- if (size > max_string_literal_size_) {
- return false;
- }
-
if (size > buffer_.size()) {
need_more_data_ = true;
return false;
@@ -159,15 +153,11 @@ bool HpackInputStream::DecodeNextHuffmanString(string* str) {
return false;
}
- HpackInputStream bounded_reader(max_string_literal_size_,
- StringPiece(buffer_.data(), encoded_size));
+ HpackInputStream bounded_reader(StringPiece(buffer_.data(), encoded_size));
buffer_.remove_prefix(encoded_size);
parsed_bytes_current_ += encoded_size;
- // DecodeString will not append more than |max_string_literal_size_| chars
- // to |str|.
- return HpackHuffmanDecoder::DecodeString(&bounded_reader,
- max_string_literal_size_, str);
+ return HpackHuffmanDecoder::DecodeString(&bounded_reader, str);
}
bool HpackInputStream::PeekBits(size_t* peeked_count, uint32_t* out) const {
« no previous file with comments | « net/spdy/hpack/hpack_input_stream.h ('k') | net/spdy/hpack/hpack_input_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698