Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Issue 2026583002: MacViews: Use native SadTabView in mac_views_browser. (Closed)

Created:
4 years, 6 months ago by kirr
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Use native SadTabView in mac_views_browser. Fixed SadTab in MacViews. BUG=615871 Committed: https://crrev.com/93e85928af1507d34e3ec3735bdb041c438e1d37 Cr-Commit-Position: refs/heads/master@{#396826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -20 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
kirr
PTAL. I'm using native cocoa view instead views::SatTabView because seems like WebContents should be implemented ...
4 years, 6 months ago (2016-05-30 16:13:28 UTC) #3
Avi (use Gerrit)
I think that the first part of the change, moving the code to run the ...
4 years, 6 months ago (2016-05-30 16:21:18 UTC) #4
tapted
On 2016/05/30 16:21:18, Avi wrote: > I think that the first part of the change, ...
4 years, 6 months ago (2016-05-31 12:27:22 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026583002/1
4 years, 6 months ago (2016-05-31 12:47:13 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-31 13:36:19 UTC) #9
Avi (use Gerrit)
On 2016/05/31 12:27:22, tapted wrote: > On 2016/05/30 16:21:18, Avi wrote: > > I think ...
4 years, 6 months ago (2016-05-31 14:34:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026583002/1
4 years, 6 months ago (2016-05-31 14:50:18 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 14:55:24 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 14:56:52 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93e85928af1507d34e3ec3735bdb041c438e1d37
Cr-Commit-Position: refs/heads/master@{#396826}

Powered by Google App Engine
This is Rietveld 408576698