Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 2026583002: MacViews: Use native SadTabView in mac_views_browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 4cda996c64bb3f040661ffe7ac5118ab6eef0cef..9d7e2b07de78a9d80f610a1f76dc7eb8e457a74f 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -83,7 +83,6 @@
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/command.h"
#include "chrome/common/pref_names.h"
-#include "chrome/common/url_constants.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/grit/locale_settings.h"
#include "components/bookmarks/browser/bookmark_model.h"
@@ -184,8 +183,6 @@ using l10n_util::GetNSStringFWithFixup;
// longer indicate that the window is shrinking from an apparent zoomed state)
// and if it's set we continue to constrain the resize.
-using content::OpenURLParams;
-using content::Referrer;
using content::RenderWidgetHostView;
using content::WebContents;
@@ -1705,17 +1702,6 @@ void SetUpBrowserWindowCommandHandler(NSWindow* window) {
[self layoutSubviews];
}
-// Handle the openLearnMoreAboutCrashLink: action from SadTabView when
-// "Learn more" link in "Aw snap" page (i.e. crash page or sad tab) is
-// clicked. Decoupling the action from its target makes unit testing possible.
-- (void)openLearnMoreAboutCrashLink:(id)sender {
- if (WebContents* contents = [self webContents]) {
- OpenURLParams params(GURL(chrome::kCrashReasonURL), Referrer(), CURRENT_TAB,
- ui::PAGE_TRANSITION_LINK, false);
- contents->OpenURL(params);
- }
-}
-
// Delegate method called when window did move. (See below for why we don't use
// |-windowWillMove:|, which is called less frequently than |-windowDidMove|
// instead.)
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698