Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Issue 2026563002: [json] implement InternalizeJSONProperty in C++. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[json] implement InternalizeJSONProperty in C++. R=cbruni@chromium.org Committed: https://crrev.com/c32a4f53b193b89cdfbaf4f2c454953d6defc917 Cr-Commit-Position: refs/heads/master@{#36604}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase and address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -77 lines) Patch
M src/api.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M src/js/json.js View 1 chunk +1 line, -43 lines 0 comments Download
M src/json-parser.h View 1 chunk +29 lines, -3 lines 0 comments Download
M src/json-parser.cc View 1 2 chunks +85 lines, -2 lines 0 comments Download
M src/json-stringifier.cc View 1 2 chunks +7 lines, -19 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-json.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
4 years, 6 months ago (2016-05-30 13:40:11 UTC) #1
Camillo Bruni
LGTM with nit https://codereview.chromium.org/2026563002/diff/1/src/json-stringifier.cc File src/json-stringifier.cc (right): https://codereview.chromium.org/2026563002/diff/1/src/json-stringifier.cc#newcode544 src/json-stringifier.cc:544: Handle<String> key(String::cast(contents->get(i))); nit: pass in the ...
4 years, 6 months ago (2016-05-30 14:25:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026563002/20001
4 years, 6 months ago (2016-05-31 05:12:49 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-31 05:43:48 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 05:45:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c32a4f53b193b89cdfbaf4f2c454953d6defc917
Cr-Commit-Position: refs/heads/master@{#36604}

Powered by Google App Engine
This is Rietveld 408576698