[json] implement InternalizeJSONProperty in C++.

src/json-stringifier.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/json-stringifier.h"
 
 #include "src/conversions.h"
 #include "src/lookup.h"
 #include "src/messages.h"
 #include "src/objects-inl.h"
@@ skipping 515 matching lines @@
   StackPop();
   return SUCCESS;
 }
 
 JsonStringifier::Result JsonStringifier::SerializeJSReceiverSlow(
     Handle<JSReceiver> object) {
   Handle<FixedArray> contents = property_list_;
   if (contents.is_null()) {
     ASSIGN_RETURN_ON_EXCEPTION_VALUE(
         isolate_, contents,
-        KeyAccumulator::GetKeys(object, OWN_ONLY, ENUMERABLE_STRINGS),
+        KeyAccumulator::GetKeys(object, OWN_ONLY, ENUMERABLE_STRINGS,
+                                CONVERT_TO_STRING),
         EXCEPTION);
   }
   builder_.AppendCharacter('{');
   Indent();
   bool comma = false;
   for (int i = 0; i < contents->length(); i++) {
-    Object* key = contents->get(i);
-    Handle<String> key_handle;
-    MaybeHandle<Object> maybe_property;
-    if (key->IsString()) {
-      key_handle = Handle<String>(String::cast(key), isolate_);
-      maybe_property = Object::GetPropertyOrElement(object, key_handle);
-    } else {
-      DCHECK(key->IsNumber());
-      key_handle = factory()->NumberToString(Handle<Object>(key, isolate_));
-      if (key->IsSmi()) {
-        maybe_property =
-            JSReceiver::GetElement(isolate_, object, Smi::cast(key)->value());
-      } else {
-        maybe_property = Object::GetPropertyOrElement(object, key_handle);
-      }
-    }
+    Handle<String> key(String::cast(contents->get(i)));

[Camillo Bruni, 2016/05/30 14:25:20]

nit: pass in the isolate_ directly

     Handle<Object> property;
-    ASSIGN_RETURN_ON_EXCEPTION_VALUE(isolate_, property, maybe_property,
+    ASSIGN_RETURN_ON_EXCEPTION_VALUE(isolate_, property,
+                                     Object::GetPropertyOrElement(object, key),
                                      EXCEPTION);
-    Result result = SerializeProperty(property, comma, key_handle);
+    Result result = SerializeProperty(property, comma, key);
     if (!comma && result == SUCCESS) comma = true;
     if (result == EXCEPTION) return result;
   }
   Unindent();
   if (comma) NewLine();
   builder_.AppendCharacter('}');
   return SUCCESS;
 }
 
 JsonStringifier::Result JsonStringifier::SerializeJSProxy(
     Handle<JSProxy> object) {
+  HandleScope scope(isolate_);
   Result stack_push = StackPush(object);
   if (stack_push != SUCCESS) return stack_push;
   Maybe<bool> is_array = Object::IsArray(object);
   if (is_array.IsNothing()) return EXCEPTION;
   if (is_array.FromJust()) {
     Handle<Object> length_object;
     ASSIGN_RETURN_ON_EXCEPTION_VALUE(
         isolate_, length_object,
         Object::GetLengthFromArrayLike(isolate_, object), EXCEPTION);
     uint32_t length;
@@ skipping 109 matching lines @@
     if (object->IsOneByteRepresentationUnderneath()) {
       SerializeString_<uint8_t, uc16>(object);
     } else {
       SerializeString_<uc16, uc16>(object);
     }
   }
 }
 
 }  // namespace internal
 }  // namespace v8