Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2026343002: Don't use hasAttribute in SVGFilterPrimitiveStandardAttributes (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
Reviewers:
pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use hasAttribute in SVGFilterPrimitiveStandardAttributes Use isSpecified() to query for existance in setStandardAttributes. This avoids triggering unnecessary attribute synchronizations. While here, drop the "double precondition" checking since the only caller of this function checks this already. BUG=235256 Committed: https://crrev.com/bfcc836db3fdba3ac761b1fe41c3347e75c31f94 Cr-Commit-Position: refs/heads/master@{#397202}

Patch Set 1 #

Patch Set 2 : Margin collapsing - boo! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
A third_party/WebKit/LayoutTests/svg/animations/filter-primitive-region.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/animations/filter-primitive-region-expected.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
fs
Looked like this was the only mole left in this bug. Whack it.
4 years, 6 months ago (2016-06-01 18:26:44 UTC) #3
pdr.
Nice nice nice! LGTM
4 years, 6 months ago (2016-06-01 19:13:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026343002/20001
4 years, 6 months ago (2016-06-01 19:16:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 19:22:12 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 19:23:45 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bfcc836db3fdba3ac761b1fe41c3347e75c31f94
Cr-Commit-Position: refs/heads/master@{#397202}

Powered by Google App Engine
This is Rietveld 408576698