Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp

Issue 2026343002: Don't use hasAttribute in SVGFilterPrimitiveStandardAttributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Margin collapsing - boo! Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/animations/filter-primitive-region-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp b/third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp
index 88455f2c326d97c3046016407e2e573da46945e5..d519fa548e97f97a007f86aef4879d856b4d9dff 100644
--- a/third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp
@@ -92,17 +92,15 @@ void SVGFilterPrimitiveStandardAttributes::childrenChanged(const ChildrenChange&
void SVGFilterPrimitiveStandardAttributes::setStandardAttributes(FilterEffect* filterEffect) const
{
- ASSERT(filterEffect);
- if (!filterEffect)
- return;
+ DCHECK(filterEffect);
- if (hasAttribute(SVGNames::xAttr))
+ if (x()->isSpecified())
filterEffect->setHasX(true);
- if (hasAttribute(SVGNames::yAttr))
+ if (y()->isSpecified())
filterEffect->setHasY(true);
- if (hasAttribute(SVGNames::widthAttr))
+ if (width()->isSpecified())
filterEffect->setHasWidth(true);
- if (hasAttribute(SVGNames::heightAttr))
+ if (height()->isSpecified())
filterEffect->setHasHeight(true);
}
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/animations/filter-primitive-region-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698