appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py - Issue 2026283002: [Findit] Adding logic to force try jobs regardless of bailout or previous results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py

Issue 2026283002: [Findit] Adding logic to force try jobs regardless of bailout or previous results (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Addressing comments and rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/start_try_job_on_demand_pipeline.py ('k') | appengine/findit/waterfall/test/analyze_build_failure_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py

diff --git a/appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py b/appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py

index e0b6f3932b7f5ac481539efaab151c0f342f792b..954e975693a4e6d7fdb894ad9470af1a9a533c30 100644

--- a/appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py

+++ b/appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py

@@ -46,7 +46,7 @@ class SwarmingTasksToTryJobPipeline(BasePipeline):

def run(

self, master_name, builder_name, build_number, good_revision,

bad_revision, blame_list, try_job_type, compile_targets=None,

- targeted_tests=None, suspected_cls=None):

+ targeted_tests=None, suspected_cls=None, force_try_job=False):

# A list contains tuples of step_names and classified_tests from

# ProcessSwarmingTaskResultPipeline.

@@ -72,8 +72,9 @@ class SwarmingTasksToTryJobPipeline(BasePipeline):

logging.info(logging_str)

classified_tests_by_step.append(step_future)

- # Waits until classified_tests_by_step are ready.

+ # Waits until classified_tests_by_step are ready.

yield RunTryJobForReliableFailurePipeline(

master_name, builder_name, build_number, good_revision,

bad_revision, blame_list, try_job_type, compile_targets,

- targeted_base_tests, suspected_cls, *classified_tests_by_step)

+ targeted_base_tests, suspected_cls, force_try_job,

+ *classified_tests_by_step)